Bug 187757 – Fix message of NotSupportedError exception thrown during custom element creation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Frédéric Wang (:fredw)]

Fix message of NotSupportedError exception thrown during custom element creation

[Frédéric Wang (:fredw)]

Created attachment 345241 [details]
Patch

[Frédéric Wang (:fredw)]

I guess we should really have a test to verify the text, but the tests from bug 161528 just check the exceptions...

[Yusuke Suzuki]

Comment on attachment 345241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345241&action=review

> Source/WebCore/ChangeLog:13
> +        No new tests, the exceptions are already tested but the actual text is non-standard.

Can we add a WebKit specific test validating these messages?

[EWS Watchlist]

Comment on attachment 345241 [details]
Patch

Attachment 345241 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8574796

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 345247 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Frédéric Wang (:fredw)]

Created attachment 345340 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 345340 [details]
Patch for landing

Clearing flags on attachment: 345340

Committed r233980: <https://trac.webkit.org/changeset/233980>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42375336>

[Frédéric Wang (:fredw)]

(In reply to Yusuke Suzuki from comment #3)
> Comment on attachment 345241 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345241&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        No new tests, the exceptions are already tested but the actual text is non-standard.
> 
> Can we add a WebKit specific test validating these messages?

Yeah, I was reluctant to duplicate existing tests but I did it when I landed this patch.