Bug 187751 - [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
Summary: [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 187385
  Show dependency treegraph
 
Reported: 2018-07-18 00:52 PDT by Zan Dobersek
Modified: 2018-07-18 03:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.68 KB, patch)
2018-07-18 01:05 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (9.69 KB, patch)
2018-07-18 03:17 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-07-18 00:52:12 PDT
[CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
Comment 1 Zan Dobersek 2018-07-18 01:05:25 PDT
Created attachment 345232 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-07-18 01:34:21 PDT
Comment on attachment 345232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116
> +    return m_nicosia.layer;

Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead.

> Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:435
> +    // TODO: Start using the Nicosia layer state for updates.

Use FIXME instead of TODO
Comment 3 Zan Dobersek 2018-07-18 03:13:55 PDT
Comment on attachment 345232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116
>> +    return m_nicosia.layer;
> 
> Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead.

It can't be null. But every time this is called, it wants a RefPtr that can then be copied. Changing this into a const reference means bending over backwards to get it back into a RefPtr<> at every callsite.
Comment 4 Zan Dobersek 2018-07-18 03:17:23 PDT
Created attachment 345234 [details]
Patch for landing
Comment 5 Zan Dobersek 2018-07-18 03:20:23 PDT
Comment on attachment 345234 [details]
Patch for landing

Clearing flags on attachment: 345234

Committed r233909: <https://trac.webkit.org/changeset/233909>
Comment 6 Zan Dobersek 2018-07-18 03:20:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-07-18 03:21:25 PDT
<rdar://problem/42328098>