Bug 187751 – [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState

[Zan Dobersek]

Created attachment 345232 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 345232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116
> +    return m_nicosia.layer;

Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead.

> Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:435
> +    // TODO: Start using the Nicosia layer state for updates.

Use FIXME instead of TODO

[Zan Dobersek]

Comment on attachment 345232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116
>> +    return m_nicosia.layer;
> 
> Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead.

It can't be null. But every time this is called, it wants a RefPtr that can then be copied. Changing this into a const reference means bending over backwards to get it back into a RefPtr<> at every callsite.

[Zan Dobersek]

Created attachment 345234 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 345234 [details]
Patch for landing

Clearing flags on attachment: 345234

Committed r233909: <https://trac.webkit.org/changeset/233909>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42328098>