Bug 187721 - [Web Animations] Interpolation between lengths with an "auto" value should be discrete
Summary: [Web Animations] Interpolation between lengths with an "auto" value should be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 186487
  Show dependency treegraph
 
Reported: 2018-07-16 18:24 PDT by Antoine Quint
Modified: 2018-07-17 11:56 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.00 KB, patch)
2018-07-16 18:26 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.28 MB, application/zip)
2018-07-16 19:21 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews101 for mac-sierra (2.88 MB, application/zip)
2018-07-16 19:39 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews205 for win-future (13.05 MB, application/zip)
2018-07-16 20:09 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (3.54 MB, application/zip)
2018-07-16 20:21 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.77 MB, application/zip)
2018-07-16 20:24 PDT, EWS Watchlist
no flags Details
Patch (7.80 KB, patch)
2018-07-17 10:09 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.46 MB, application/zip)
2018-07-17 11:13 PDT, EWS Watchlist
no flags Details
Patch for landing (8.85 KB, patch)
2018-07-17 11:15 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-07-16 18:24:03 PDT
[Web Animations] Interpolation between lengths with an "auto" value should be discrete
Comment 1 Antoine Quint 2018-07-16 18:26:23 PDT
Created attachment 345134 [details]
Patch
Comment 2 EWS Watchlist 2018-07-16 19:21:22 PDT
Comment on attachment 345134 [details]
Patch

Attachment 345134 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8559038

New failing tests:
imported/blink/transitions/transition-not-interpolable.html
fast/animation/height-auto-transition-computed-value.html
legacy-animation-engine/imported/blink/transitions/transition-not-interpolable.html
legacy-animation-engine/fast/animation/height-auto-transition-computed-value.html
Comment 3 EWS Watchlist 2018-07-16 19:21:24 PDT
Created attachment 345136 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-07-16 19:39:05 PDT
Comment on attachment 345134 [details]
Patch

Attachment 345134 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8559128

New failing tests:
imported/blink/transitions/transition-not-interpolable.html
fast/animation/height-auto-transition-computed-value.html
legacy-animation-engine/imported/blink/transitions/transition-not-interpolable.html
legacy-animation-engine/fast/animation/height-auto-transition-computed-value.html
Comment 5 EWS Watchlist 2018-07-16 19:39:07 PDT
Created attachment 345138 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-07-16 20:09:03 PDT
Comment on attachment 345134 [details]
Patch

Attachment 345134 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8559199

New failing tests:
imported/blink/transitions/transition-not-interpolable.html
fast/animation/height-auto-transition-computed-value.html
legacy-animation-engine/imported/blink/transitions/transition-not-interpolable.html
legacy-animation-engine/fast/animation/height-auto-transition-computed-value.html
Comment 7 EWS Watchlist 2018-07-16 20:09:15 PDT
Created attachment 345142 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 EWS Watchlist 2018-07-16 20:21:25 PDT
Comment on attachment 345134 [details]
Patch

Attachment 345134 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8559152

New failing tests:
imported/blink/transitions/transition-not-interpolable.html
fast/animation/height-auto-transition-computed-value.html
legacy-animation-engine/imported/blink/transitions/transition-not-interpolable.html
legacy-animation-engine/fast/animation/height-auto-transition-computed-value.html
Comment 9 EWS Watchlist 2018-07-16 20:21:26 PDT
Created attachment 345144 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-07-16 20:24:25 PDT
Comment on attachment 345134 [details]
Patch

Attachment 345134 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8559190

New failing tests:
imported/blink/transitions/transition-not-interpolable.html
legacy-animation-engine/imported/blink/transitions/transition-not-interpolable.html
Comment 11 EWS Watchlist 2018-07-16 20:24:26 PDT
Created attachment 345145 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 12 Antoine Quint 2018-07-17 10:09:36 PDT
Created attachment 345163 [details]
Patch
Comment 13 Dean Jackson 2018-07-17 10:58:50 PDT
Comment on attachment 345163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345163&action=review

> Source/WebCore/ChangeLog:9
> +        from 0 and up to (but excluding) 5, and use the to-value from 0.5 to 1.

You meant 0.5
Comment 14 EWS Watchlist 2018-07-17 11:13:05 PDT
Comment on attachment 345163 [details]
Patch

Attachment 345163 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8564789

New failing tests:
legacy-animation-engine/transitions/transition-to-from-auto.html
Comment 15 EWS Watchlist 2018-07-17 11:13:06 PDT
Created attachment 345170 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 16 Antoine Quint 2018-07-17 11:15:14 PDT
Created attachment 345171 [details]
Patch for landing
Comment 17 WebKit Commit Bot 2018-07-17 11:54:12 PDT
Comment on attachment 345171 [details]
Patch for landing

Clearing flags on attachment: 345171

Committed r233892: <https://trac.webkit.org/changeset/233892>
Comment 18 WebKit Commit Bot 2018-07-17 11:54:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 19 Radar WebKit Bug Importer 2018-07-17 11:56:26 PDT
<rdar://problem/42295437>