Bug 187717 - Add color filter for transforming colors in Dark Mode
Summary: Add color filter for transforming colors in Dark Mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-16 16:55 PDT by Simon Fraser (smfr)
Modified: 2018-07-16 19:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (49.32 KB, patch)
2018-07-16 16:57 PDT, Simon Fraser (smfr)
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-16 16:55:21 PDT
Add color filter for transforming colors in Dark Mode
Comment 1 Simon Fraser (smfr) 2018-07-16 16:57:30 PDT
Created attachment 345130 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-07-16 16:57:49 PDT
rdar://problem/41146650
Comment 3 EWS Watchlist 2018-07-16 17:01:00 PDT
Attachment 345130 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:277:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:282:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:293:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:407:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 5 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2018-07-16 19:04:19 PDT
Comment on attachment 345130 [details]
Patch

Dean reviewed this
Comment 5 Simon Fraser (smfr) 2018-07-16 19:04:42 PDT
https://trac.webkit.org/changeset/233877/webkit