Bug 187713 - Release assert in ~TimerBase is getting hit in WK1 apps which uses JSC API directly
Summary: Release assert in ~TimerBase is getting hit in WK1 apps which uses JSC API di...
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: InRadar
Depends on:
Reported: 2018-07-16 15:29 PDT by Ryosuke Niwa
Modified: 2018-07-16 19:50 PDT (History)
5 users (show)

See Also:

Fixes the crash (1.81 KB, patch)
2018-07-16 15:31 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed non-iOS builds (1.95 KB, patch)
2018-07-16 16:10 PDT, Ryosuke Niwa
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-07-16 15:29:19 PDT
Apparently, JSC API doesn't grab the web thread lock, as a result, some apps are hitting the release assertion in ~TimerBase.

Comment 1 Ryosuke Niwa 2018-07-16 15:31:03 PDT
Created attachment 345124 [details]
Fixes the crash
Comment 2 Mark Lam 2018-07-16 15:45:23 PDT
The GTK and wpe build failure looks legit.
Comment 3 Ryosuke Niwa 2018-07-16 16:10:09 PDT
Created attachment 345128 [details]
Fixed non-iOS builds
Comment 4 Simon Fraser (smfr) 2018-07-16 19:09:02 PDT
Comment on attachment 345128 [details]
Fixed non-iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=345128&action=review

> Source/WebCore/ChangeLog:8
> +        Turn this into a debug assertion in WebKit1.

This needs more explanation that mentions the JSC lack of WebThreadLock etc, and reference a radar.
Comment 5 Ryosuke Niwa 2018-07-16 19:50:13 PDT
Committed r233879: <https://trac.webkit.org/changeset/233879>