Bug 187711 - [ MacOS WK1 Debug ] Layout Test svg/custom/linking-uri-01-b.svg is flakey
Summary: [ MacOS WK1 Debug ] Layout Test svg/custom/linking-uri-01-b.svg is flakey
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-16 14:57 PDT by Truitt Savell
Modified: 2018-07-17 16:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.31 KB, patch)
2018-07-16 15:03 PDT, Truitt Savell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2018-07-16 14:57:39 PDT
The following layout test is failing on MacOS WK1 Debug

svg/custom/linking-uri-01-b.svg

Probable cause:

Test has been highly intermittent for a while it seems. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=svg%2Fcustom%2Flinking-uri-01-b.svg

Test Diff:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r233852%20(8677)/svg/custom/linking-uri-01-b-diff.txt
Comment 1 Truitt Savell 2018-07-16 15:03:28 PDT
Created attachment 345121 [details]
Patch
Comment 2 EWS 2018-07-16 15:05:39 PDT
Comment on attachment 345121 [details]
Patch

Rejecting attachment 345121 [details] from commit-queue.

tsavell@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 WebKit Commit Bot 2018-07-16 16:53:56 PDT
Comment on attachment 345121 [details]
Patch

Clearing flags on attachment: 345121

Committed r233871: <https://trac.webkit.org/changeset/233871>
Comment 4 WebKit Commit Bot 2018-07-16 16:53:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-16 16:54:18 PDT
<rdar://problem/42263028>
Comment 6 Alexey Proskuryakov 2018-07-17 16:01:17 PDT
The main problem here is that the SVG is rendered at a wrong size:

+  RenderSVGRoot {svg} at (0,0) size 480x360
-  RenderSVGRoot {svg} at (0,0) size 800x600

Definitely worth figuring out how to reproduce. The test is very basic, so whatever causes this problem may well be breaking other tests too.