Bug 187704 - jsc shell's noFTL utility test function should be more robust.
Summary: jsc shell's noFTL utility test function should be more robust.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-16 11:04 PDT by Mark Lam
Modified: 2018-07-16 11:43 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch. (1.54 KB, patch)
2018-07-16 11:13 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-07-16 11:04:53 PDT
<rdar://problem/42231988>
Comment 1 Mark Lam 2018-07-16 11:13:20 PDT
Created attachment 345102 [details]
proposed patch.
Comment 2 Michael Saboff 2018-07-16 11:34:25 PDT
Comment on attachment 345102 [details]
proposed patch.

r=me
Comment 3 Keith Miller 2018-07-16 11:34:41 PDT
Comment on attachment 345102 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review

r=me.

> Source/JavaScriptCore/jsc.cpp:1443
> +    if (exec->argumentCount() >= 1) {

Nit: you can just do if (exec->argumentCount()) here.
Comment 4 Mark Lam 2018-07-16 11:38:52 PDT
Comment on attachment 345102 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review

>> Source/JavaScriptCore/jsc.cpp:1443
>> +    if (exec->argumentCount() >= 1) {
> 
> Nit: you can just do if (exec->argumentCount()) here.

Will fix before landing.
Comment 5 Mark Lam 2018-07-16 11:43:02 PDT
Thanks for the review.  Landed in r233854: <http://trac.webkit.org/r233854>.