Bug 187691 - Web Inspector: Dark Mode: selected item background color is too light
Summary: Web Inspector: Dark Mode: selected item background color is too light
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-15 20:07 PDT by Nikita Vasilyev
Modified: 2018-07-16 09:29 PDT (History)
5 users (show)

See Also:


Attachments
[Image] Bug (70.77 KB, image/png)
2018-07-15 20:07 PDT, Nikita Vasilyev
no flags Details
Patch (2.12 KB, patch)
2018-07-15 20:20 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.82 MB, application/zip)
2018-07-16 00:05 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-07-15 20:07:38 PDT
Created attachment 345074 [details]
[Image] Bug

Selected item background color in Xcode is noticeably darker than in Web Inspector.
Comment 1 Radar WebKit Bug Importer 2018-07-15 20:07:51 PDT
<rdar://problem/42225308>
Comment 2 Nikita Vasilyev 2018-07-15 20:20:58 PDT
Created attachment 345076 [details]
Patch
Comment 3 EWS Watchlist 2018-07-16 00:04:59 PDT
Comment on attachment 345076 [details]
Patch

Attachment 345076 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8549160

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-07-16 00:05:10 PDT
Created attachment 345082 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 BJ Burg 2018-07-16 09:02:53 PDT
Comment on attachment 345076 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2018-07-16 09:29:07 PDT
Comment on attachment 345076 [details]
Patch

Clearing flags on attachment: 345076

Committed r233847: <https://trac.webkit.org/changeset/233847>
Comment 7 WebKit Commit Bot 2018-07-16 09:29:08 PDT
All reviewed patches have been landed.  Closing bug.