Bug 187683 - Shrink CompositeAnimation and AnimationBase
Summary: Shrink CompositeAnimation and AnimationBase
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2018-07-14 17:16 PDT by Simon Fraser (smfr)
Modified: 2018-07-18 00:03 PDT (History)
9 users (show)

See Also:

Patch (4.16 KB, patch)
2018-07-14 17:17 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-14 17:16:10 PDT
Shrink CompositeAnimation and AnimationBase
Comment 1 Simon Fraser (smfr) 2018-07-14 17:17:04 PDT
Created attachment 345044 [details]
Comment 2 Antoine Quint 2018-07-16 10:30:36 PDT
Comment on attachment 345044 [details]

I was a bit puzzled by this patch since there was no explanation as to why the member variables were declared in a different spot. Ideally there would be a comment or an assertion if the class size exceeds the expected amount. Then we could refer back to this patch as good practice for memory-efficient classes.
Comment 3 Daniel Bates 2018-07-16 20:06:32 PDT
Comment on attachment 345044 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=345044&action=review

We may want to consider taking a similar approach as RenderStyle? and add static asserts to prevent a size regression.

> Source/WebCore/ChangeLog:8
> +        Reduce the size of CompositeAnimation and AnimationBase.

How much did we reduce it by?
Comment 4 WebKit Commit Bot 2018-07-18 00:02:09 PDT
Comment on attachment 345044 [details]

Clearing flags on attachment: 345044

Committed r233908: <https://trac.webkit.org/changeset/233908>
Comment 5 WebKit Commit Bot 2018-07-18 00:02:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-18 00:03:27 PDT