Bug 187680 - Shrink some style-related classes and enums
Summary: Shrink some style-related classes and enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-14 16:12 PDT by Simon Fraser (smfr)
Modified: 2018-07-14 17:30 PDT (History)
5 users (show)

See Also:


Attachments
Patch (34.44 KB, patch)
2018-07-14 16:17 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-14 16:12:03 PDT
Shrink some style-related classes and enums
Comment 1 Simon Fraser (smfr) 2018-07-14 16:17:42 PDT
Created attachment 345040 [details]
Patch
Comment 2 Antti Koivisto 2018-07-14 16:31:22 PDT
Comment on attachment 345040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345040&action=review

> Source/WebCore/ChangeLog:12
> +        Shrink DocumentRuleSet from 384 to 368 bytes by re-ordering, which also helps shrink
> +        StyleResolver from 1024 to 952 bytes.

Micro-optimizing low volume objects like DocumentRuleSet does not produce meaningful gain. Still, cleanups are nice.
Comment 3 WebKit Commit Bot 2018-07-14 17:29:35 PDT
Comment on attachment 345040 [details]
Patch

Clearing flags on attachment: 345040

Committed r233838: <https://trac.webkit.org/changeset/233838>
Comment 4 WebKit Commit Bot 2018-07-14 17:29:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-14 17:30:30 PDT
<rdar://problem/42207689>