Bug 187675 - CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
Summary: CustomConfigurationTestGroupForm should dispatch different arguments based on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-13 18:40 PDT by dewei_zhu
Modified: 2018-07-16 22:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2018-07-13 18:46 PDT, dewei_zhu
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-07-13 18:40:08 PDT
CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
Comment 1 dewei_zhu 2018-07-13 18:46:06 PDT
Created attachment 345014 [details]
Patch
Comment 2 Ryosuke Niwa 2018-07-16 20:00:38 PDT
Comment on attachment 345014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345014&action=review

> Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js:41
> +        if (!this._hasTask)

We should assert that !!this._hasTask == !taskName
Comment 3 dewei_zhu 2018-07-16 22:18:21 PDT
Landed in r233884.