Bug 187667 - Ensure WebKit stack is ad-hoc signed
Summary: Ensure WebKit stack is ad-hoc signed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-13 15:49 PDT by Kocsen Chung
Modified: 2018-07-14 16:45 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.34 KB, patch)
2018-07-13 15:50 PDT, Kocsen Chung 		no flags Details | Formatted Diff | Diff
Patch (9.31 KB, patch)
2018-07-13 16:02 PDT, Kocsen Chung 		ap: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.33 MB, application/zip)
2018-07-13 17:44 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews200 for win-future (12.76 MB, application/zip)
2018-07-13 20:37 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kocsen Chung 2018-07-13 15:49:49 PDT 
Ensure WebKit stack is ad-hoc signed
Comment 1 Kocsen Chung 2018-07-13 15:50:58 PDT 
Created attachment 344997 [details]
Patch
Comment 2 EWS Watchlist 2018-07-13 15:53:41 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 EWS Watchlist 2018-07-13 15:53:51 PDT 
Attachment 344997 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Kocsen Chung 2018-07-13 16:02:05 PDT 
Created attachment 344999 [details]
Patch
Comment 5 Alexey Proskuryakov 2018-07-13 17:28:28 PDT 
Comment on attachment 344999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344999&action=review

Looks reasonable to me. I'm not sure what's up with mac-wk2 EWS. Probably the machine is in a bad state, but who knows what repercussions this patch has.

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:3
> +CODE_SIGN_IDENTITY = - ;

I wouldn't be adding spaces before the semicolon.
Comment 6 EWS Watchlist 2018-07-13 17:44:46 PDT 
Comment on attachment 344999 [details]
Patch

Attachment 344999 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8531181

Number of test failures exceeded the failure limit.
Comment 7 EWS Watchlist 2018-07-13 17:44:48 PDT 
Created attachment 345009 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-07-13 20:37:29 PDT 
Comment on attachment 344999 [details]
Patch

Attachment 344999 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8532721

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 9 EWS Watchlist 2018-07-13 20:37:41 PDT 
Created attachment 345017 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 10 Alexey Proskuryakov 2018-07-14 16:45:21 PDT 
Tested locally, and WebKit2 tests pass. Must have been a bot condition.

Committed http://trac.webkit.org/r233837