Bug 187667 – Ensure WebKit stack is ad-hoc signed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kocsen Chung]

Ensure WebKit stack is ad-hoc signed

[Kocsen Chung]

Created attachment 344997 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[EWS Watchlist]

Attachment 344997 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kocsen Chung]

Created attachment 344999 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 344999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344999&action=review

Looks reasonable to me. I'm not sure what's up with mac-wk2 EWS. Probably the machine is in a bad state, but who knows what repercussions this patch has.

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:3
> +CODE_SIGN_IDENTITY = - ;

I wouldn't be adding spaces before the semicolon.

[EWS Watchlist]

Comment on attachment 344999 [details]
Patch

Attachment 344999 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8531181

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 345009 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 344999 [details]
Patch

Attachment 344999 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8532721

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 345017 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alexey Proskuryakov]

Tested locally, and WebKit2 tests pass. Must have been a bot condition.

Committed http://trac.webkit.org/r233837