Bug 187665 – Add _drawsBackground to WKWebViewConfiguration

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Timothy Hatcher]

WebViews that need to be transparent often flash white before _drawsBackground can be set to NO on the WKWebView.

Add _drawsBackground to WKWebViewConfiguration so it can be passed in at instantiation.

[Radar WebKit Bug Importer]

<rdar://problem/42182268>

[Tim Horton]

Why do they flash? It’s in WebPageCreationParameters, so as long as it’s set *before* clients load (and thus launch a process) (and also as long as they do it in the same runloop as they create the view), shouldn’t that be sufficient?

[Timothy Hatcher]

Created attachment 344991 [details]
Patch

[Anders Carlsson]

Comment on attachment 344991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344991&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:312
> +    self._drawsBackground = [coder decodeBoolForKey:@"drawsBackground"];

Shouldn't this default to YES if the key is missing?

[Timothy Hatcher]

Created attachment 344996 [details]
Patch

[Tim Horton]

Comment on attachment 344996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344996&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:45
> +TEST(WebKit, ConfigurationDrawsBackground)

Tests! Crazy.

[EWS Watchlist]

Comment on attachment 344996 [details]
Patch

Attachment 344996 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8530702

New failing tests:
accessibility/smart-invert-reference.html

[EWS Watchlist]

Created attachment 345002 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Comment on attachment 344996 [details]
Patch

Clearing flags on attachment: 344996

Committed r233828: <https://trac.webkit.org/changeset/233828>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.