Bug 187665 - Add _drawsBackground to WKWebViewConfiguration
Summary: Add _drawsBackground to WKWebViewConfiguration
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
Keywords: InRadar
Depends on:
Reported: 2018-07-13 14:56 PDT by Timothy Hatcher
Modified: 2018-07-13 17:03 PDT (History)
6 users (show)

See Also:

Patch (12.10 KB, patch)
2018-07-13 15:22 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2018-07-13 15:49 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.70 MB, application/zip)
2018-07-13 16:42 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-07-13 14:56:25 PDT
WebViews that need to be transparent often flash white before _drawsBackground can be set to NO on the WKWebView.

Add _drawsBackground to WKWebViewConfiguration so it can be passed in at instantiation.
Comment 1 Radar WebKit Bug Importer 2018-07-13 14:57:03 PDT
Comment 2 Tim Horton 2018-07-13 15:19:34 PDT
Why do they flash? It’s in WebPageCreationParameters, so as long as it’s set *before* clients load (and thus launch a process) (and also as long as they do it in the same runloop as they create the view), shouldn’t that be sufficient?
Comment 3 Timothy Hatcher 2018-07-13 15:22:29 PDT Comment hidden (obsolete)
Comment 4 Anders Carlsson 2018-07-13 15:23:40 PDT Comment hidden (obsolete)
Comment 5 Timothy Hatcher 2018-07-13 15:49:16 PDT
Created attachment 344996 [details]
Comment 6 Tim Horton 2018-07-13 16:06:46 PDT
Comment on attachment 344996 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=344996&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:45
> +TEST(WebKit, ConfigurationDrawsBackground)

Tests! Crazy.
Comment 7 EWS Watchlist 2018-07-13 16:42:36 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-07-13 16:42:38 PDT Comment hidden (obsolete)
Comment 9 WebKit Commit Bot 2018-07-13 17:03:55 PDT
Comment on attachment 344996 [details]

Clearing flags on attachment: 344996

Committed r233828: <https://trac.webkit.org/changeset/233828>
Comment 10 WebKit Commit Bot 2018-07-13 17:03:57 PDT
All reviewed patches have been landed.  Closing bug.