The following layout test is flaky on MacOS and iOS storage/indexeddb/modern/opendatabase-after-storage-crash.html Probable cause: Test was introduced in r233562 <https://trac.webkit.org/changeset/233562/webkit> It started as a flakey Failure and Timeout. The timeout issue was resolved in r233599 <https://trac.webkit.org/changeset/233599/webkit> Test is now a flakey failure. It has several different failure outputs linked below: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r233794%20(4094)/storage/indexeddb/modern/opendatabase-after-storage-crash-diff.txt https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r233746%20(4072)/storage/indexeddb/modern/opendatabase-after-storage-crash-diff.txt https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r233678%20(4041)/storage/indexeddb/modern/opendatabase-after-storage-crash-diff.txt https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r233641%20(4029)/storage/indexeddb/modern/opendatabase-after-storage-crash-diff.txt Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fopendatabase-after-storage-crash.html Creating this bug to track this test. Original Bug: https://bugs.webkit.org/show_bug.cgi?id=187123
Looks like it's failing about half of the time now. @@ -1 +1 @@ -Successfully opened the database in a new document +Unexpected success during the first database open on document load. DB opening: opendatabase-after-storage-crash.htmlTue Jul 17 2018 12:03:43 GMT-0700 (PDT). Version opening: 1. SessionStorage value: undefined
I've tried to fix this a few times. It's current inexplicable to me why the failure that is still happening is possible. *sigh*
Marked test as flaky in https://trac.webkit.org/r234015.
<rdar://problem/42405935>
Created attachment 345413 [details] Patch
Comment on attachment 345413 [details] Patch You should remove the mark-as-flaky
Created attachment 345490 [details] Patch for landing
Comment on attachment 345490 [details] Patch for landing Clearing flags on attachment: 345490 Committed r234077: <https://trac.webkit.org/changeset/234077>
All reviewed patches have been landed. Closing bug.
after https://trac.webkit.org/changeset/234077 We began to see tests in the svg/ directory begin to flake randomly. This issue is detailed in https://bugs.webkit.org/show_bug.cgi?id=187931 I found that after this change to storage/indexeddb/modern/opendatabase-after-storage-crash.html that this test would set a state that caused any test in the svg/ directory to have a chance of timeout. I have skipped this test in: https://trac.webkit.org/changeset/234602/webkit
Created attachment 346666 [details] Patch
Created attachment 346852 [details] Patch
Comment on attachment 346852 [details] Patch Rejecting attachment 346852 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 346852, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=346852&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=187648&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 346852 from bug 187648. Fetching: https://bugs.webkit.org/attachment.cgi?id=346852 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/wk2/TestExpectations M LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: Commits are currently disabled while we update infrastructure. W: eed6554d82f4ac9a175e722742f09c327e278291 and refs/remotes/origin/master differ, using rebase: :040000 040000 c39453c186f0451c3e13da98f776e98f671cdf31 9631be1100237ff43f4ef7c0005cc5185c77722d M LayoutTests Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/wk2/TestExpectations M LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: Commits are currently disabled while we update infrastructure. W: eed6554d82f4ac9a175e722742f09c327e278291 and refs/remotes/origin/master differ, using rebase: :040000 040000 c39453c186f0451c3e13da98f776e98f671cdf31 9631be1100237ff43f4ef7c0005cc5185c77722d M LayoutTests Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Total errors found: 0 in 1 files Full output: https://webkit-queues.webkit.org/results/8977468
Comment on attachment 346852 [details] Patch Clearing flags on attachment: 346852 Committed r235415: <https://trac.webkit.org/changeset/235415>