Bug 187647 - Add more threading release assertions
Summary: Add more threading release assertions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-13 10:13 PDT by Chris Dumez
Modified: 2022-03-01 02:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2018-07-13 10:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.40 KB, patch)
2018-07-13 10:17 PDT, Chris Dumez 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-13 10:13:39 PDT 
Add more threading release assertions to help debug <rdar://problem/39265927>.
Comment 1 Chris Dumez 2018-07-13 10:15:09 PDT 
Created attachment 344951 [details]
Patch
Comment 2 Chris Dumez 2018-07-13 10:17:51 PDT 
Created attachment 344952 [details]
Patch
Comment 3 Alex Christensen 2018-07-13 11:43:27 PDT 
Comment on attachment 344952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344952&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:760
> +    RELEASE_ASSERT(RunLoop::isMain());

All the other assertions are at the beginning of the function.
Comment 4 Chris Dumez 2018-07-13 11:47:26 PDT 
Committed r233808: <https://trac.webkit.org/changeset/233808>
Comment 5 Radar WebKit Bug Importer 2018-07-13 11:48:20 PDT 
<rdar://problem/42174774>