Bug 187643 - [GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc Encoders
Summary: [GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on: 186932
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-13 08:17 PDT by Thibault Saunier
Modified: 2018-07-24 02:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.93 KB, patch)
2018-07-13 08:35 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (8.96 KB, patch)
2018-07-13 15:47 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (8.96 KB, patch)
2018-07-23 07:58 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-07-13 08:17:54 PDT 
[GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc Encoders
Comment 1 Thibault Saunier 2018-07-13 08:35:04 PDT 
Created attachment 344946 [details]
Patch
Comment 2 Thibault Saunier 2018-07-13 15:47:27 PDT 
Created attachment 344995 [details]
Patch

Fix small bitrate conversion issue
Comment 3 Philippe Normand 2018-07-19 02:12:40 PDT 
Comment on attachment 344995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344995&action=review

LGTM!

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:389
> +        if (caps && m_profile.get() && gst_caps_is_equal (m_restrictionCaps.get(), caps))

No space before (
Comment 4 Thibault Saunier 2018-07-23 07:57:24 PDT 
(In reply to Philippe Normand from comment #3)
> Comment on attachment 344995 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344995&action=review
> 
> LGTM!
> 
> > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:389
> > +        if (caps && m_profile.get() && gst_caps_is_equal (m_restrictionCaps.get(), caps))
> 
> No space before (

Fixed.
Comment 5 Thibault Saunier 2018-07-23 07:58:41 PDT 
Created attachment 345572 [details]
Patch
Comment 6 Philippe Normand 2018-07-24 01:28:13 PDT 
Comment on attachment 345572 [details]
Patch

Let's see if this lands :)
Comment 7 WebKit Commit Bot 2018-07-24 02:08:18 PDT 
Comment on attachment 345572 [details]
Patch

Clearing flags on attachment: 345572

Committed r234141: <https://trac.webkit.org/changeset/234141>
Comment 8 WebKit Commit Bot 2018-07-24 02:08:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-07-24 02:09:18 PDT 
<rdar://problem/42533922>