Bug 187623 - PiP from Element Fullscreen should match AVKit's behavior
Summary: PiP from Element Fullscreen should match AVKit's behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-12 15:48 PDT by Jer Noble
Modified: 2018-07-19 09:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (38.15 KB, patch)
2018-07-13 11:01 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.74 MB, application/zip)
2018-07-13 12:15 PDT, EWS Watchlist 		no flags Details
Patch (62.46 KB, patch)
2018-07-16 12:27 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (75.35 KB, patch)
2018-07-16 14:12 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (75.55 KB, patch)
2018-07-16 15:07 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (75.01 KB, patch)
2018-07-17 19:05 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-07-12 15:48:27 PDT 
PiP from Element Fullscreen should match AVKit's behavior
Comment 1 Jer Noble 2018-07-13 11:00:58 PDT 
<rdar://problem/41212379>
Comment 2 Jer Noble 2018-07-13 11:01:50 PDT 
Created attachment 344957 [details]
Patch
Comment 3 EWS Watchlist 2018-07-13 12:15:28 PDT 
Comment on attachment 344957 [details]
Patch

Attachment 344957 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8527032

New failing tests:
media/fullscreen-video-going-into-pip.html
media/video-contained-in-fullscreen-element-going-into-pip.html
Comment 4 EWS Watchlist 2018-07-13 12:15:30 PDT 
Created attachment 344964 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Jer Noble 2018-07-16 12:27:15 PDT 
Created attachment 345110 [details]
Patch
Comment 6 Jer Noble 2018-07-16 14:12:13 PDT 
Created attachment 345118 [details]
Patch
Comment 7 Jer Noble 2018-07-16 15:07:09 PDT 
Created attachment 345122 [details]
Patch
Comment 8 Jer Noble 2018-07-17 19:05:56 PDT 
Created attachment 345217 [details]
Patch
Comment 9 WebKit Commit Bot 2018-07-18 12:50:12 PDT 
Comment on attachment 345217 [details]
Patch

Clearing flags on attachment: 345217

Committed r233926: <https://trac.webkit.org/changeset/233926>
Comment 10 WebKit Commit Bot 2018-07-18 12:50:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Jer Noble 2018-07-18 15:30:49 PDT 
Committed build fix in r233930: <http://trac.webkit.org/r233930>.
Committed API test fix in r233936: <http://trac.webkit.org/r233936>.
Comment 12 Truitt Savell 2018-07-19 09:58:06 PDT 
The revision r233926: <https://trac.webkit.org/changeset/233926> caused this test to constantly Timeout: 

media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

Test History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-pip-to-inline.html