Summary: Type token positioning should use line/column locations from Esprima instead of offsets. TypeTokenAnnotator calculates positions for type tokens using offsets from Esprima AST nodes. Once CodeMirror returns to auto-detecting line endings (see https://webkit.org/b/186453), these offsets won't correspond to CodeMirror's offsets for the same tokens.
<rdar://problem/42131910>
Created attachment 344872 [details] Patch
Comment on attachment 344872 [details] Patch Attachment 344872 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8519412 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Created attachment 344887 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 344872 [details] Patch r=me
Comment on attachment 344872 [details] Patch Clearing flags on attachment: 344872 Committed r233792: <https://trac.webkit.org/changeset/233792>
All reviewed patches have been landed. Closing bug.