Bug 187612 - Web Inspector: Type token positioning should use line/column locations from Esprima instead of offsets
Summary: Web Inspector: Type token positioning should use line/column locations from E...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 186453 187532
  Show dependency treegraph
 
Reported: 2018-07-12 12:00 PDT by Matt Baker
Modified: 2018-07-12 19:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (13.55 KB, patch)
2018-07-12 12:23 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.97 MB, application/zip)
2018-07-12 15:10 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-12 12:00:54 PDT
Summary:
Type token positioning should use line/column locations from Esprima instead of offsets.

TypeTokenAnnotator calculates positions for type tokens using offsets from Esprima AST nodes. Once CodeMirror returns to auto-detecting line endings (see https://webkit.org/b/186453), these offsets won't correspond to CodeMirror's offsets for the same tokens.
Comment 1 Radar WebKit Bug Importer 2018-07-12 12:10:16 PDT
<rdar://problem/42131910>
Comment 2 Matt Baker 2018-07-12 12:23:17 PDT
Created attachment 344872 [details]
Patch
Comment 3 EWS Watchlist 2018-07-12 15:10:08 PDT
Comment on attachment 344872 [details]
Patch

Attachment 344872 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8519412

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-07-12 15:10:20 PDT
Created attachment 344887 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Joseph Pecoraro 2018-07-12 16:45:08 PDT
Comment on attachment 344872 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-07-12 19:06:55 PDT
Comment on attachment 344872 [details]
Patch

Clearing flags on attachment: 344872

Committed r233792: <https://trac.webkit.org/changeset/233792>
Comment 7 WebKit Commit Bot 2018-07-12 19:06:56 PDT
All reviewed patches have been landed.  Closing bug.