187595 – [WPE] Three grid related tests are flaky

Bug 187595 - [WPE] Three grid related tests are flaky

Summary: [WPE] Three grid related tests are flaky

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WPE WebKit (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2018-07-12 06:56 PDT by Miguel Gomez
Modified:	2020-06-15 07:25 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Miguel Gomez 2018-07-12 06:56:28 PDT

imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002.html [ Failure Pass ]

Fails every 10 releases more or less. This is the diff when it happens:

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002-actual.txt
@@ -4,13 +4,13 @@
   <div class="marginBottom50Percent" data-expected-margin-bottom="50" data-offset-y="440" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="10" data-offset-y="400" data-expected-width="10" data-expected-height="100"></div>
 </div>
-offsetTop expected 440 but got 365
+offsetTop expected 440 but got 428
 FAIL .grid 2 assert_equals: 
 <div class="grid directionRTL">
   <div class="marginTop50Percent" data-expected-margin-top="50" data-offset-y="490" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="10" data-offset-y="400" data-expected-width="10" data-expected-height="100"></div>
 </div>
-margin-top expected "50" but got "125"
+margin-top expected "50" but got "62.5"
 PASS .grid 3 
 PASS .grid 4 
 FAIL .grid 5 assert_equals: 
@@ -18,13 +18,13 @@
   <div class="marginBottom50Percent" data-expected-margin-bottom="50" data-offset-y="0" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="10" data-offset-y="0" data-expected-width="10" data-expected-height="100"></div>
 </div>
-margin-bottom expected "50" but got "125"
+margin-bottom expected "50" but got "62.5"
 FAIL .grid 6 assert_equals: 
 <div class="grid">
   <div class="marginTop50Percent" data-expected-margin-top="50" data-offset-y="50" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="10" data-offset-y="0" data-expected-width="10" data-expected-height="100"></div>
 </div>
-offsetTop expected 50 but got 125
+offsetTop expected 50 but got 63
 PASS .grid 7 
 PASS .grid 8 
 Direction LTR

Comment 1 Miguel Gomez 2018-07-26 07:12:14 PDT

There are 2 more tests related to this that are flaky in a quite similar than the original one:

imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-002.html [ Failure Pass ]

whose diff when it fails is

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-002-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-002-actual.txt
@@ -6,13 +6,13 @@
   <div class="marginRight50Percent" data-expected-margin-right="50" data-offset-x="440" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="400" data-offset-y="10" data-expected-width="100" data-expected-height="10"></div>
 </div>
-offsetLeft expected 440 but got 365
+offsetLeft expected 440 but got 428
 FAIL .grid 4 assert_equals: 
 <div class="grid directionRTL">
   <div class="marginLeft50Percent" data-expected-margin-left="50" data-offset-x="490" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="400" data-offset-y="10" data-expected-width="100" data-expected-height="10"></div>
 </div>
-margin-left expected "50" but got "125"
+margin-left expected "50" but got "62.5"
 PASS .grid 5 
 PASS .grid 6 
 FAIL .grid 7 assert_equals: 
@@ -20,13 +20,13 @@
   <div class="marginRight50Percent" data-expected-margin-right="50" data-offset-x="0" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="0" data-offset-y="10" data-expected-width="100" data-expected-height="10"></div>
 </div>
-margin-right expected "50" but got "125"
+margin-right expected "50" but got "62.5"
 FAIL .grid 8 assert_equals: 
 <div class="grid">
   <div class="marginLeft50Percent" data-expected-margin-left="50" data-offset-x="50" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="0" data-offset-y="10" data-expected-width="100" data-expected-height="10"></div>
 </div>
-offsetLeft expected 50 but got 125
+offsetLeft expected 50 but got 63
 Direction LTR
 
 Item margin-left: 50%;



and imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002.html [ Failure Pass ]

whose diff is

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002-actual.txt
@@ -4,13 +4,13 @@
   <div class="marginBottom50Percent" data-expected-margin-bottom="50" data-expected-y="440" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="0" data-offset-y="400" data-expected-width="10" data-expected-height="100"></div>
 </div>
-margin-bottom expected "50" but got "125"
+margin-bottom expected "50" but got "62.5"
 FAIL .grid 2 assert_equals: 
 <div class="grid directionRTL">
   <div class="marginTop50Percent" data-expected-margin-top="50" data-expected-y="490" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="0" data-offset-y="400" data-expected-width="10" data-expected-height="100"></div>
 </div>
-margin-top expected "50" but got "125"
+margin-top expected "50" but got "62.5"
 PASS .grid 3 
 PASS .grid 4 
 FAIL .grid 5 assert_equals: 
@@ -18,13 +18,13 @@
   <div class="marginBottom50Percent" data-expected-margin-bottom="50" data-offset-y="0" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="100"></div>
 </div>
-margin-bottom expected "50" but got "125"
+margin-bottom expected "50" but got "62.5"
 FAIL .grid 6 assert_equals: 
 <div class="grid">
   <div class="marginTop50Percent" data-expected-margin-top="50" data-offset-y="50" data-expected-width="10" data-expected-height="10">X</div>
   <div data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="100"></div>
 </div>
-offsetTop expected 50 but got 125
+offsetTop expected 50 but got 63
 PASS .grid 7 
 PASS .grid 8 
 Direction LTR

Comment 2 Diego Pino 2020-06-15 07:25:59 PDT

The test(s) filed under this bug have been consistently passing for the last 4000 revisions. Marking bug as fixed.

Committed r263034: <https://trac.webkit.org/changeset/263034>