187573 – Make WebKit.LinkColorWithSystemAppearance work across system versions

RESOLVED FIXED 187573

Make WebKit.LinkColorWithSystemAppearance work across system versions

https://bugs.webkit.org/show_bug.cgi?id=187573

Summary Make WebKit.LinkColorWithSystemAppearance work across system versions

Timothy Hatcher

Reported 2018-07-11 17:51:39 PDT

The [NSColor linkColor] is different between 10.14 and earlier macOS releases. Make this test work in all cases.

Attachments
Patch (1.86 KB, patch) 2018-07-11 17:52 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (2.06 KB, patch) 2018-07-12 10:30 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (2.06 KB, patch) 2018-07-12 10:59 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2018-07-11 17:52:59 PDT Comment hidden (obsolete)

Created attachment 344800 [details] Patch

Wenson Hsieh

Comment 2 2018-07-12 08:28:14 PDT Comment hidden (obsolete)

Comment on attachment 344800 [details] Patch I might be missing something here, but it looks like +[NSColor linkColor] only exists in <AppKit/NSColor.h> on macOS Mojave (despite NS_AVAILABLE_MAC(10_10) in the header).

Wenson Hsieh

Comment 3 2018-07-12 08:32:58 PDT Comment hidden (obsolete)

(In reply to Wenson Hsieh from comment #2) > Comment on attachment 344800 [details] > Patch > > I might be missing something here, but it looks like +[NSColor linkColor] > only exists in <AppKit/NSColor.h> on macOS Mojave (despite > NS_AVAILABLE_MAC(10_10) in the header). Ah, that being said, +[NSColor linkColor] is SPI in NSColor_Private.h on Sierra and High Sierra SDKs, where its availability is declared as NS_AVAILABLE_MAC(10_10). I'm not sure if transferring the same availability over to the public header was an intentional change in Mojave...but it seems like we need to forward declare this to get it to build on the open source WebKit bots.

Timothy Hatcher

Comment 4 2018-07-12 08:47:58 PDT Comment hidden (obsolete)

Sigh, yep. We declare it in our NSColorSPI.h. I’ll just include that.

Timothy Hatcher

Comment 5 2018-07-12 10:30:58 PDT Comment hidden (obsolete)

Created attachment 344858 [details] Patch

Timothy Hatcher

Comment 6 2018-07-12 10:59:19 PDT

Created attachment 344861 [details] Patch

WebKit Commit Bot

Comment 7 2018-07-12 11:37:54 PDT

Comment on attachment 344861 [details] Patch Clearing flags on attachment: 344861 Committed r233775: <https://trac.webkit.org/changeset/233775>

WebKit Commit Bot

Comment 8 2018-07-12 11:37:56 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-07-12 11:38:19 PDT

<rdar://problem/42130497>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Timothy Hatcher

Reported

2018-07-11 17:51 PDT

Modified

2018-07-12 11:38 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks