Bug 187563 - Add compile guard for enabling NSRunLoop in the WebContent process.
Summary: Add compile guard for enabling NSRunLoop in the WebContent process.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-11 14:14 PDT by Per Arne Vollan
Modified: 2018-07-12 09:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.93 KB, patch)
2018-07-11 14:31 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (13.08 KB, patch)
2018-07-12 07:37 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-07-11 14:14:54 PDT 
Also, we should replace __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) where appropriate.
Comment 1 Per Arne Vollan 2018-07-11 14:31:49 PDT 
Created attachment 344782 [details]
Patch
Comment 2 Chris Dumez 2018-07-11 14:38:37 PDT 
Comment on attachment 344782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344782&action=review

> Source/WTF/wtf/FeatureDefines.h:245
> +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400

Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on ENABLE_WEBPROCESS_NSRUNLOOP being 1?
Comment 3 Per Arne Vollan 2018-07-12 07:37:31 PDT 
Created attachment 344843 [details]
Patch
Comment 4 Per Arne Vollan 2018-07-12 07:38:25 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 344782 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344782&action=review
> 
> > Source/WTF/wtf/FeatureDefines.h:245
> > +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
> 
> Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on
> ENABLE_WEBPROCESS_NSRUNLOOP being 1?

Thanks for reviewing! I have updated the patch.
Comment 5 Chris Dumez 2018-07-12 08:30:32 PDT 
Comment on attachment 344843 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-07-12 09:02:18 PDT 
Comment on attachment 344843 [details]
Patch

Clearing flags on attachment: 344843

Committed r233769: <https://trac.webkit.org/changeset/233769>
Comment 7 WebKit Commit Bot 2018-07-12 09:02:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-12 09:03:26 PDT 
<rdar://problem/42123360>