Bug 187561 – [32bit JSC tests] stress/cow-convert-double-to-contiguous.js and stress/cow-convert-int32-to-contiguous.js are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dawei Fenton (:realdawei)]

Created attachment 344780 [details]
stdio

JSC stress test failures have been introduced:
	stress/cow-convert-double-to-contiguous.js.default
	stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit
	stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases
	stress/cow-convert-double-to-contiguous.js.no-llint
	stress/cow-convert-int32-to-contiguous.js.default
	stress/cow-convert-int32-to-contiguous.js.dfg-maximal-flush-validate-no-cjit
	stress/cow-convert-int32-to-contiguous.js.no-cjit-validate-phases
	stress/cow-convert-int32-to-contiguous.js.no-llint

[Dawei Fenton (:realdawei)]

These tests were added on 5/22 https://trac.webkit.org/changeset/232070/webkit

However began failing somewhere in the range r232904 - 232909

Excerpt from stdio:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2269/steps/webkit-32bit-jsc-test/logs/stdio

stress/cow-convert-double-to-contiguous.js.default: Exception: Error: test should be === to 2.0585345
stress/cow-convert-double-to-contiguous.js.default: [e-mail]:8:24
stress/cow-convert-double-to-contiguous.js.default: [e-mail]:17:13
stress/cow-convert-double-to-contiguous.js.default: global [e-mail]:28:9
stress/cow-convert-double-to-contiguous.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/cow-convert-double-to-contiguous.js.default
Running stress/cow-convert-double-to-contiguous.js.no-llint
stress/cow-convert-double-to-contiguous.js.no-llint: Exception: Error: test should be === to 2.0585345
stress/cow-convert-double-to-contiguous.js.no-llint: [e-mail]:8:24
stress/cow-convert-double-to-contiguous.js.no-llint: [e-mail]:17:13
stress/cow-convert-double-to-contiguous.js.no-llint: global [e-mail]:28:9
stress/cow-convert-double-to-contiguous.js.no-llint: ERROR: Unexpected exit code: 3
FAIL: stress/cow-convert-double-to-contiguous.js.no-llint
Running stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases
Running stress/cow-convert-double-to-contiguous.js.dfg-eager
stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases: Exception: Error: test should be === to 2.0585345
stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases: [e-mail]:8:24
stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases: [e-mail]:17:13
stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases: global [e-mail]:28:9
stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases: ERROR: Unexpected exit code: 3
FAIL: stress/cow-convert-double-to-contiguous.js.no-cjit-validate-phases
Running stress/cow-convert-double-to-contiguous.js.dfg-eager-no-cjit-validate
Running stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit
Running stress/cow-convert-int32-to-array-storage.js.default
stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit: Exception: Error: test should be === to 2.0585345
stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit: [e-mail]:8:24
stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit: [e-mail]:17:13
stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit: global [e-mail]:28:9
stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit: ERROR: Unexpected exit code: 3
FAIL: stress/cow-convert-double-to-contiguous.js.dfg-maximal-flush-validate-no-cjit

[Ryan Haddad]

*** Bug 187560 has been marked as a duplicate of this bug. ***

[Ryan Haddad]

(In reply to David Fenton (:realdawei) from comment #1)
> These tests were added on 5/22
> https://trac.webkit.org/changeset/232070/webkit
> 
> However began failing somewhere in the range r232904 - 232909

https://trac.webkit.org/changeset/232904/webkit seems like a suspect

[Yusuke Suzuki]

I guess this is a CoW array bug: r232904 fixes another bug in CoW array and it reveals the existing issue.

[Yusuke Suzuki]

Created attachment 344833 [details]
Patch

[Yusuke Suzuki]

Created attachment 344834 [details]
Patch

[Yusuke Suzuki]

we need to reduce 32bit code......

[EWS Watchlist]

Comment on attachment 344834 [details]
Patch

Attachment 344834 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8516155

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

[EWS Watchlist]

Created attachment 344856 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Yusuke Suzuki]

Comment on attachment 344834 [details]
Patch

Thank you!

[WebKit Commit Bot]

Comment on attachment 344834 [details]
Patch

Clearing flags on attachment: 344834

Committed r233806: <https://trac.webkit.org/changeset/233806>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42173722>