Bug 18756 - Fix dependency problem in --clean
Summary: Fix dependency problem in --clean
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Kevin Ollivier
Depends on:
Reported: 2008-04-26 13:33 PDT by Robin Dunn
Modified: 2008-04-27 22:23 PDT (History)
0 users

See Also:

patch for build-wxwebkit (1.55 KB, patch)
2008-04-26 13:35 PDT, Robin Dunn
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Dunn 2008-04-26 13:33:59 PDT
On Windows when doing a --clean of a wx build then the derived sources directories get deleted before the makefile clean target is processed.  Since it has some dependencies on the derived sources then the make fails.  This patch simple reverses the order things are done.

It also moves the _webview.dll to _webview.pyd.
Comment 1 Robin Dunn 2008-04-26 13:35:19 PDT
Created attachment 20832 [details]
patch for build-wxwebkit
Comment 2 Kevin Ollivier 2008-04-26 19:32:43 PDT
landed in r32600, thanks! :)
Comment 3 Maciej Stachowiak 2008-04-27 22:23:40 PDT
Comment on attachment 20832 [details]
patch for build-wxwebkit

Retroactive r+ since this was landed.