Bug 187558 – Make process-swap-on-navigation an experimental feature

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Make process-swap-on-navigation an experimental feature

This is so it can show up in Safari/SafariTechnologyPreviews menus automatically

[Brady Eidson]

<rdar://problem/41995053>

[Brady Eidson]

Have a WIP but having problems verifying its working for various other reasons related to the state of the tree *sigh*

[Brady Eidson]

(In reply to Brady Eidson from comment #2)
> Have a WIP but having problems verifying its working for various other
> reasons related to the state of the tree *sigh*

More precisely, the state of process swapping in the tree.

There's been regressions in process swapping apparently uncaught by the existing layouttests and API tests.

[Brady Eidson]

Created attachment 344777 [details]
Patch

[Geoffrey Garen]

Comment on attachment 344777 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 344777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344777&action=review

> Source/WebKit/UIProcess/WebPreferences.cpp:139
> +            pools.add(&page->process().processPool());

I think technically, it wouldn't hurt to call setProcessSwapsOnNavigation() on the process pool here right away. Not convinced it is worth using a HashSet here.

[Brady Eidson]

(In reply to Chris Dumez from comment #6)
> Comment on attachment 344777 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344777&action=review
> 
> > Source/WebKit/UIProcess/WebPreferences.cpp:139
> > +            pools.add(&page->process().processPool());
> 
> I think technically, it wouldn't hurt to call setProcessSwapsOnNavigation()
> on the process pool here right away. Not convinced it is worth using a
> HashSet here.

Hmmmmm  Yah, it's a tough call.

"Normal" case not worth it.

Extreme case probably worth it.

I'll change it.

[Brady Eidson]

Created attachment 344779 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 344779 [details]
Patch

Clearing flags on attachment: 344779

Committed r233741: <https://trac.webkit.org/changeset/233741>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This seems to be causing (at least) the Sierra testers to run out of processes while running layout tests:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/10502

[WebKit Commit Bot]

Re-opened since this is blocked by bug 187568

[Brady Eidson]

Created attachment 344814 [details]
Patch

[Brady Eidson]

(In reply to Ryan Haddad from comment #11)
> This seems to be causing (at least) the Sierra testers to run out of
> processes while running layout tests:
> https://build.webkit.org/builders/
> Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/10502

For those who weren't on IRC earlier:
This is because WebKitTestRunner always turns on all experimental features, so by making this an experimental feature it was getting turned on against my intent.

[EWS Watchlist]

Comment on attachment 344814 [details]
Patch

Attachment 344814 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8511681

New failing tests:
http/tests/navigation/process-swap-window-open.html

[EWS Watchlist]

Created attachment 344820 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 344814 [details]
Patch

Attachment 344814 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8511768

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 344824 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 344814 [details]
Patch

Attachment 344814 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8511727

New failing tests:
http/tests/navigation/process-swap-window-open.html

[EWS Watchlist]

Created attachment 344825 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Brady Eidson]

Created attachment 344870 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 344870 [details]
Patch

Clearing flags on attachment: 344870

Committed r233786: <https://trac.webkit.org/changeset/233786>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.