Make process-swap-on-navigation an experimental feature This is so it can show up in Safari/SafariTechnologyPreviews menus automatically
<rdar://problem/41995053>
Have a WIP but having problems verifying its working for various other reasons related to the state of the tree *sigh*
(In reply to Brady Eidson from comment #2) > Have a WIP but having problems verifying its working for various other > reasons related to the state of the tree *sigh* More precisely, the state of process swapping in the tree. There's been regressions in process swapping apparently uncaught by the existing layouttests and API tests.
Created attachment 344777 [details] Patch
Comment on attachment 344777 [details] Patch r=me
Comment on attachment 344777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344777&action=review > Source/WebKit/UIProcess/WebPreferences.cpp:139 > + pools.add(&page->process().processPool()); I think technically, it wouldn't hurt to call setProcessSwapsOnNavigation() on the process pool here right away. Not convinced it is worth using a HashSet here.
(In reply to Chris Dumez from comment #6) > Comment on attachment 344777 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344777&action=review > > > Source/WebKit/UIProcess/WebPreferences.cpp:139 > > + pools.add(&page->process().processPool()); > > I think technically, it wouldn't hurt to call setProcessSwapsOnNavigation() > on the process pool here right away. Not convinced it is worth using a > HashSet here. Hmmmmm Yah, it's a tough call. "Normal" case not worth it. Extreme case probably worth it. I'll change it.
Created attachment 344779 [details] Patch
Comment on attachment 344779 [details] Patch Clearing flags on attachment: 344779 Committed r233741: <https://trac.webkit.org/changeset/233741>
All reviewed patches have been landed. Closing bug.
This seems to be causing (at least) the Sierra testers to run out of processes while running layout tests: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/10502
Re-opened since this is blocked by bug 187568
Created attachment 344814 [details] Patch
(In reply to Ryan Haddad from comment #11) > This seems to be causing (at least) the Sierra testers to run out of > processes while running layout tests: > https://build.webkit.org/builders/ > Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/10502 For those who weren't on IRC earlier: This is because WebKitTestRunner always turns on all experimental features, so by making this an experimental feature it was getting turned on against my intent.
Comment on attachment 344814 [details] Patch Attachment 344814 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8511681 New failing tests: http/tests/navigation/process-swap-window-open.html
Created attachment 344820 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 344814 [details] Patch Attachment 344814 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8511768 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Created attachment 344824 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 344814 [details] Patch Attachment 344814 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8511727 New failing tests: http/tests/navigation/process-swap-window-open.html
Created attachment 344825 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 344870 [details] Patch
Comment on attachment 344870 [details] Patch Clearing flags on attachment: 344870 Committed r233786: <https://trac.webkit.org/changeset/233786>