Bug 187544 - Disable all network caching for HLS streams.
Summary: Disable all network caching for HLS streams.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-10 17:46 PDT by Jer Noble
Modified: 2018-07-11 16:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2018-07-10 17:48 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2018-07-10 18:22 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2018-07-11 11:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-07-10 17:46:06 PDT 
Disable all network caching for HLS streams.
Comment 1 Jer Noble 2018-07-10 17:46:23 PDT 
<rdar://problem/41863600>
Comment 2 Jer Noble 2018-07-10 17:48:54 PDT 
Created attachment 344740 [details]
Patch
Comment 3 Jer Noble 2018-07-10 18:22:00 PDT 
Created attachment 344743 [details]
Patch
Comment 4 youenn fablet 2018-07-10 19:23:09 PDT 
Comment on attachment 344743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344743&action=review

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:661
> +        return NO;

I am not sure this is sufficient to disable caching in the NetworkProcess.
Maybe setting FetchOptions.cache to FetchOptions::Cache::NoStore in MediaResourceLoader when we return NO here would do the trick.
Comment 5 Jer Noble 2018-07-11 11:43:19 PDT 
Created attachment 344774 [details]
Patch
Comment 6 WebKit Commit Bot 2018-07-11 12:30:06 PDT 
Comment on attachment 344774 [details]
Patch

Clearing flags on attachment: 344774

Committed r233738: <https://trac.webkit.org/changeset/233738>
Comment 7 WebKit Commit Bot 2018-07-11 12:30:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Antti Koivisto 2018-07-11 16:09:13 PDT 
Comment on attachment 344774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344774&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:265
>      // FIXME: We should introduce a separate media cache partition that doesn't affect other resources.
>      // FIXME: We should also make sure make the MSE paths are copy-free so we can use mapped buffers from disk effectively.

These FIXMEs don't make much sense now either and could be removed.