Bug 187536 - [IOS] We should prevent WebProcess suspension while the UIProcess is waiting for a reply from its injected bundle
Summary: [IOS] We should prevent WebProcess suspension while the UIProcess is waiting ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-10 15:53 PDT by Chris Dumez
Modified: 2018-07-10 17:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.76 KB, patch)
2018-07-10 16:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-10 15:53:59 PDT
We should prevent WebProcess suspension while the UIProcess is waiting for a reply from its injected bundle (RemoteObjectRegistry API). Otherwise, the reply block may end up never getting called because the WebProcess was suspended on iOS. We already do this for callbacks on the WebPageProxy, however, RemoteObjectRegistry has is own mechanism which currently does not take any process assertions.
Comment 1 Chris Dumez 2018-07-10 15:54:16 PDT
<rdar://problem/41931912>
Comment 2 Chris Dumez 2018-07-10 16:05:17 PDT
Created attachment 344729 [details]
Patch
Comment 3 WebKit Commit Bot 2018-07-10 17:09:18 PDT
Comment on attachment 344729 [details]
Patch

Clearing flags on attachment: 344729

Committed r233713: <https://trac.webkit.org/changeset/233713>
Comment 4 WebKit Commit Bot 2018-07-10 17:09:19 PDT
All reviewed patches have been landed.  Closing bug.