StorageProcess::createStorageToWebProcessConnection and StorageProcessProxy::didCreateStorageToWebProcessConnection have no windows implementations. This is causing the webprocess' main thread to indefinitely lock when attempting to use the storage process.
Created attachment 344722 [details] patch
Comment on attachment 344722 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=344722&action=review I'm not a reviewer. This is an informal review. > Source/WebKit/StorageProcess/StorageProcess.cpp:268 > + return; I think you shouldn't ignore this error. Mac port is calling LOG_ERROR and CRASH in case of error. Windows port should do the same.
(In reply to Fujii Hironori from comment #2) > Comment on attachment 344722 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344722&action=review > > I'm not a reviewer. This is an informal review. > > > Source/WebKit/StorageProcess/StorageProcess.cpp:268 > > + return; > > I think you shouldn't ignore this error. Mac port is calling LOG_ERROR and > CRASH in case of error. Windows port should do the same. It looks like the NetworkProcess::createNetworkConnectionToWebProcess also suppressed that error. I'll update that too.
Created attachment 344757 [details] patch
LGTM!
Comment on attachment 344757 [details] patch Attachment 344757 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8503116 New failing tests: http/tests/preload/onload_event.html
Created attachment 344760 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 344757 [details] patch Clearing flags on attachment: 344757 Committed r233807: <https://trac.webkit.org/changeset/233807>
All reviewed patches have been landed. Closing bug.
<rdar://problem/42173986>