Bug 187517 - [GLIB] Add API to allow creating variadic functions
Summary: [GLIB] Add API to allow creating variadic functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-07-10 06:35 PDT by Carlos Garcia Campos
Modified: 2018-07-11 22:20 PDT (History)
9 users (show)

See Also:


Attachments
Patch (32.85 KB, patch)
2018-07-10 06:41 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.79 MB, application/zip)
2018-07-10 08:42 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-07-10 06:35:25 PDT
Our current API requires to know in advance the type and number of parameters of functions, methods and constructors. So, it's not possible to expose a function, method or constructor that can receive different amount of parameters.
Comment 1 Carlos Garcia Campos 2018-07-10 06:41:25 PDT
Created attachment 344691 [details]
Patch
Comment 2 Build Bot 2018-07-10 08:42:14 PDT
Comment on attachment 344691 [details]
Patch

Attachment 344691 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8494726

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
http/tests/security/contentSecurityPolicy/video-redirect-allowed.html
Comment 3 Build Bot 2018-07-10 08:42:26 PDT
Created attachment 344698 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Michael Catanzaro 2018-07-11 06:36:34 PDT
Comment on attachment 344691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344691&action=review

> Source/JavaScriptCore/API/glib/JSCClass.cpp:645
> + * This function creates the constructor, that needs to be added to an object as a property to be able to use it. Use

that -> which
Comment 5 Carlos Garcia Campos 2018-07-11 22:18:35 PDT
Committed r233760: <https://trac.webkit.org/changeset/233760>
Comment 6 Radar WebKit Bug Importer 2018-07-11 22:20:09 PDT
<rdar://problem/42104190>