Bug 187513 - [GTK][WPE] The LibWebRTCProvider object in RealtimeMediaSourceCenterLibWebRTC is not needed anymore
Summary: [GTK][WPE] The LibWebRTCProvider object in RealtimeMediaSourceCenterLibWebRTC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-10 03:38 PDT by Alejandro G. Castro
Modified: 2018-07-10 09:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.12 KB, patch)
2018-07-10 03:42 PDT, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2018-07-10 03:38:50 PDT 
We used the factory of that provider as a singleton to make sure the devices were correctly listed and used, we needed this when using libwebrtc devices handling. We are now using GStreamer to handle de devices so this is not needed anymore.
Comment 1 Alejandro G. Castro 2018-07-10 03:42:33 PDT 
Created attachment 344684 [details]
Patch
Comment 2 Thibault Saunier 2018-07-10 04:32:43 PDT 
Comment on attachment 344684 [details]
Patch

Looks good.
Comment 3 WebKit Commit Bot 2018-07-10 09:33:11 PDT 
Comment on attachment 344684 [details]
Patch

Clearing flags on attachment: 344684

Committed r233684: <https://trac.webkit.org/changeset/233684>
Comment 4 WebKit Commit Bot 2018-07-10 09:33:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-10 09:34:20 PDT 
<rdar://problem/42027326>