Bug 187482 - Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed
Summary: Web Inspector: REGRESSION (r217505): Debugger content view doesn't update whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P1 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 14:12 PDT by Matt Baker
Modified: 2018-07-10 09:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.87 KB, patch)
2018-07-09 23:18 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-09 14:12:24 PDT 
Summary:
Debugger content view doesn't update when left sidebar is collapsed.

Steps to Reproduce (A):
1. Inspect webkit.org
2. Open Debugger tab
3. Collapse left sidebar
4. Select a new resource using the hierarchical path component in the content view's navigation bar
  => Selection does not change

Steps to Reproduce (B):
1. Inspect webkit.org
2. Open Debugger tab
3. Set a breakpoint in global.js
4. Switch to another resource in the Debugger tab (like wp-embed-min.js)
5. Collapse left sidebar
6. Reload inspected page
  => Pause in debugger, but the content view doesn't change to show the pause location
Comment 1 Radar WebKit Bug Importer 2018-07-09 14:13:30 PDT 
<rdar://problem/41989190>
Comment 2 Matt Baker 2018-07-09 16:58:20 PDT 
This regressed in http://trac.webkit.org/changeset/217505.
Comment 3 Matt Baker 2018-07-09 17:02:11 PDT 
The regression also broke navigating via the hierarchical path for Storage, Search, and Resources.
Comment 4 Matt Baker 2018-07-09 17:23:53 PDT 
(In reply to Matt Baker from comment #3)
> The regression also broke navigating via the hierarchical path for Storage,
> Search, and Resources.

Actually, StorageSidebarPanel._treeSelectionDidChange included the visible check prior to http://trac.webkit.org/changeset/217505.
Comment 5 Matt Baker 2018-07-09 23:18:14 PDT 
Created attachment 344671 [details]
Patch
Comment 6 BJ Burg 2018-07-10 09:17:49 PDT 
Comment on attachment 344671 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2018-07-10 09:44:52 PDT 
Comment on attachment 344671 [details]
Patch

Clearing flags on attachment: 344671

Committed r233686: <https://trac.webkit.org/changeset/233686>
Comment 8 WebKit Commit Bot 2018-07-10 09:44:53 PDT 
All reviewed patches have been landed.  Closing bug.