Bug 187479 – Add --traceLLIntExecution and --traceLLIntSlowPath options.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

These options are only available if LLINT_TRACING is enabled in LLIntCommon.h.

The details:
1. LLINT_TRACING consolidates and replaces LLINT_EXECUTION_TRACING and LLINT_SLOW_PATH_TRACING.
2. Tracing is now guarded behind runtime options --traceLLIntExecution and --traceLLIntSlowPath.  This makes it such that enabling LLINT_TRACING doesn't means that we'll continually spammed with logging until we rebuild.
3. Fixed slow path LLINT tracing to work with exception check validation.

[Mark Lam]

Created attachment 344605 [details]
proposed patch.

[Yusuke Suzuki]

Comment on attachment 344605 [details]
proposed patch.

r=me

[Saam Barati]

Comment on attachment 344605 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=344605&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:198
> +        dataLog(values...);

Can just be dataLogIf(Options...

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:205
> +        dataLogLn(values...);

Ditto

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:217
> +        dataLogF(format, values...);

Not sure if we have an it variant of this

[Mark Lam]

Thanks for the reviews.  Landed in r233658: <http://trac.webkit.org/r233658>.

[Radar WebKit Bug Importer]

<rdar://problem/41991662>