Bug 187479 - Add --traceLLIntExecution and --traceLLIntSlowPath options.
Summary: Add --traceLLIntExecution and --traceLLIntSlowPath options.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 13:12 PDT by Mark Lam
Modified: 2018-07-09 14:58 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (18.19 KB, patch)
2018-07-09 13:18 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-07-09 13:12:36 PDT
These options are only available if LLINT_TRACING is enabled in LLIntCommon.h.

The details:
1. LLINT_TRACING consolidates and replaces LLINT_EXECUTION_TRACING and LLINT_SLOW_PATH_TRACING.
2. Tracing is now guarded behind runtime options --traceLLIntExecution and --traceLLIntSlowPath.  This makes it such that enabling LLINT_TRACING doesn't means that we'll continually spammed with logging until we rebuild.
3. Fixed slow path LLINT tracing to work with exception check validation.
Comment 1 Mark Lam 2018-07-09 13:18:29 PDT
Created attachment 344605 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2018-07-09 13:38:48 PDT
Comment on attachment 344605 [details]
proposed patch.

r=me
Comment 3 Saam Barati 2018-07-09 13:40:51 PDT
Comment on attachment 344605 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=344605&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:198
> +        dataLog(values...);

Can just be dataLogIf(Options...

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:205
> +        dataLogLn(values...);

Ditto

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:217
> +        dataLogF(format, values...);

Not sure if we have an it variant of this
Comment 4 Mark Lam 2018-07-09 14:56:44 PDT
Thanks for the reviews.  Landed in r233658: <http://trac.webkit.org/r233658>.
Comment 5 Radar WebKit Bug Importer 2018-07-09 14:58:47 PDT
<rdar://problem/41991662>