Bug 187477 – [JSC] Embed RegExp into constant buffer in UnlinkedCodeBlock and CodeBlock

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Embed RegExp into constant buffer in UnlinkedCodeBlock and CodeBlock

[Yusuke Suzuki]

Created attachment 344598 [details]
Patch

[EWS Watchlist]

Comment on attachment 344598 [details]
Patch

Attachment 344598 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8484735

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 344609 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Mark Lam]

Comment on attachment 344598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344598&action=review

r=me with suggested change.

> Source/JavaScriptCore/runtime/JSCJSValue.cpp:277
> +            out.print("RegExp: ");
> +            RegExp::dumpToStream(asCell(), out);

If you implement WTF::printInternal (see below), then this reduces to:
    out.print("RegExp: ", jsCast<RegExp*>(asCell()));

> Source/JavaScriptCore/runtime/RegExp.cpp:528
> +void RegExp::dumpToStream(const JSCell* cell, PrintStream& out)

I recommend making this a WTF::printInternal instead so that we can use it with dataLog print streams directly.  Grep for "printInternal(PrintStream&" for examples.

[Yusuke Suzuki]

Comment on attachment 344598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344598&action=review

Thanks!

>> Source/JavaScriptCore/runtime/JSCJSValue.cpp:277
>> +            RegExp::dumpToStream(asCell(), out);
> 
> If you implement WTF::printInternal (see below), then this reduces to:
>     out.print("RegExp: ", jsCast<RegExp*>(asCell()));

I've changed this code to `out.print("RegExp: ", *jsCast<RegExp*>(asCell())));`. It works since we override dumpToStream in RegExp.

>> Source/JavaScriptCore/runtime/RegExp.cpp:528
>> +void RegExp::dumpToStream(const JSCell* cell, PrintStream& out)
> 
> I recommend making this a WTF::printInternal instead so that we can use it with dataLog print streams directly.  Grep for "printInternal(PrintStream&" for examples.

We override RegExp::dumpToStream, which is well utilized in JSCell ClassInfo mechanism!

[Yusuke Suzuki]

Committed r233657: <https://trac.webkit.org/changeset/233657>

[Radar WebKit Bug Importer]

<rdar://problem/41990301>