Bug 187465 - [JSC] Optimize layout of AccessCase / ProxyableAccessCase to reduce size of ProxyableAccessCase
Summary: [JSC] Optimize layout of AccessCase / ProxyableAccessCase to reduce size of P...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 04:33 PDT by Yusuke Suzuki
Modified: 2018-07-09 10:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.85 KB, patch)
2018-07-09 04:40 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2018-07-09 04:47 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2018-07-09 04:50 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.24 MB, application/zip)
2018-07-09 06:38 PDT, EWS Watchlist 		no flags Details
Patch (5.22 KB, patch)
2018-07-09 06:56 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2018-07-09 07:06 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-09 04:33:04 PDT 
[JSC] Optimize layout of AccessCase / ProxyableAccessCase to reduce size of ProxyableAccessCase
Comment 1 Yusuke Suzuki 2018-07-09 04:40:50 PDT 
Created attachment 344573 [details]
Patch
Comment 2 Yusuke Suzuki 2018-07-09 04:47:56 PDT 
Created attachment 344575 [details]
Patch
Comment 3 Yusuke Suzuki 2018-07-09 04:50:08 PDT 
Created attachment 344576 [details]
Patch
Comment 4 EWS Watchlist 2018-07-09 06:38:56 PDT 
Comment on attachment 344576 [details]
Patch

Attachment 344576 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8481820

New failing tests:
animations/needs-layout.html
Comment 5 EWS Watchlist 2018-07-09 06:38:58 PDT 
Created attachment 344580 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 Yusuke Suzuki 2018-07-09 06:56:33 PDT 
Created attachment 344582 [details]
Patch
Comment 7 Yusuke Suzuki 2018-07-09 07:06:13 PDT 
Created attachment 344583 [details]
Patch
Comment 8 Keith Miller 2018-07-09 10:00:51 PDT 
Comment on attachment 344583 [details]
Patch

r=me.
Comment 9 Keith Miller 2018-07-09 10:02:48 PDT 
Comment on attachment 344583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344583&action=review

> Source/JavaScriptCore/bytecode/AccessCase.h:246
> +    // It becomes true only if the instance inherits (or it is) ProxyableAccessCase.

nit: It bocomes true => m_viaProxy is true

> Source/JavaScriptCore/bytecode/AccessCase.h:248
> +    // derived classes, which is super frequently allocated.

nit: which is => which are.
Comment 10 Yusuke Suzuki 2018-07-09 10:07:00 PDT 
Comment on attachment 344583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344583&action=review

Thanks!

>> Source/JavaScriptCore/bytecode/AccessCase.h:246
>> +    // It becomes true only if the instance inherits (or it is) ProxyableAccessCase.
> 
> nit: It bocomes true => m_viaProxy is true

Fixed.

>> Source/JavaScriptCore/bytecode/AccessCase.h:248
>> +    // derived classes, which is super frequently allocated.
> 
> nit: which is => which are.

Fixed.
Comment 11 Yusuke Suzuki 2018-07-09 10:08:22 PDT 
Committed r233644: <https://trac.webkit.org/changeset/233644>
Comment 12 Radar WebKit Bug Importer 2018-07-09 10:09:19 PDT 
<rdar://problem/41977764>