Bug 187452 - run-benchmark should run ARES-6 1.0.1
Summary: run-benchmark should run ARES-6 1.0.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-08 14:50 PDT by Filip Pizlo
Modified: 2018-07-10 15:01 PDT (History)
10 users (show)

See Also:

Attachments
the patch (2.24 KB, patch)
2018-07-08 14:50 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (1.35 KB, patch)
2018-07-08 14:52 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-07-08 14:50:23 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2018-07-08 14:50:48 PDT 
Created attachment 344552 [details]
the patch
Comment 2 Filip Pizlo 2018-07-08 14:51:17 PDT 
Comment on attachment 344552 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344552&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:41
> +        for key in os.environ:
> +            if key.startswith("__XPC_JSC"):
> +                env[key] = os.environ[key]
> +

Ooooops!  Will revert.
Comment 3 EWS Watchlist 2018-07-08 14:51:55 PDT 
Attachment 344552 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2018-07-08 14:52:11 PDT 
Created attachment 344553 [details]
the patch
Comment 5 WebKit Commit Bot 2018-07-08 16:18:54 PDT 
Comment on attachment 344553 [details]
the patch

Clearing flags on attachment: 344553

Committed r233631: <https://trac.webkit.org/changeset/233631>
Comment 6 WebKit Commit Bot 2018-07-08 16:18:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-07-08 16:19:18 PDT 
<rdar://problem/41954846>
Comment 8 Saam Barati 2018-07-09 11:11:19 PDT 
Oops. Thanks for fixing this. We should keep an eye on the bots today as we should expect some change in results.
Comment 9 dewei_zhu 2018-07-10 14:46:58 PDT 
Comment on attachment 344553 [details]
the patch

The same patch will be applied with some warnings:
patching file driver.js
Hunk #1 succeeded at 141 with fuzz 2 (offset 5 lines).
patching file index.html

I'll make a change to update the patch accoringly.
Comment 10 dewei_zhu 2018-07-10 15:01:02 PDT 
Address in r233700.