RESOLVED FIXED 187452
run-benchmark should run ARES-6 1.0.1 
https://bugs.webkit.org/show_bug.cgi?id=187452
Summary run-benchmark should run ARES-6 1.0.1
Filip Pizlo
Reported 2018-07-08 14:50:23 PDT
Patch forthcoming.
Attachments
the patch (2.24 KB, patch)
2018-07-08 14:50 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (1.35 KB, patch)
2018-07-08 14:52 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-07-08 14:50:48 PDT
Created attachment 344552 [details] the patch
Filip Pizlo
Comment 2 2018-07-08 14:51:17 PDT
Comment on attachment 344552 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=344552&action=review > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:41 > + for key in os.environ: > + if key.startswith("__XPC_JSC"): > + env[key] = os.environ[key] > + Ooooops! Will revert.
EWS Watchlist
Comment 3 2018-07-08 14:51:55 PDT
Attachment 344552 [details] did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 2018-07-08 14:52:11 PDT
Created attachment 344553 [details] the patch
WebKit Commit Bot
Comment 5 2018-07-08 16:18:54 PDT
Comment on attachment 344553 [details] the patch Clearing flags on attachment: 344553 Committed r233631: <https://trac.webkit.org/changeset/233631>
WebKit Commit Bot
Comment 6 2018-07-08 16:18:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-07-08 16:19:18 PDT
<rdar://problem/41954846>
Saam Barati
Comment 8 2018-07-09 11:11:19 PDT
Oops. Thanks for fixing this. We should keep an eye on the bots today as we should expect some change in results.
dewei_zhu
Comment 9 2018-07-10 14:46:58 PDT
Comment on attachment 344553 [details] the patch The same patch will be applied with some warnings: patching file driver.js Hunk #1 succeeded at 141 with fuzz 2 (offset 5 lines). patching file index.html I'll make a change to update the patch accoringly.
dewei_zhu
Comment 10 2018-07-10 15:01:02 PDT
Address in r233700.
Note You need to log in before you can comment on or make changes to this bug.