187443 – Shrink various loading-related enums to shrink CachedResource

RESOLVED FIXED 187443

Shrink various loading-related enums to shrink CachedResource

https://bugs.webkit.org/show_bug.cgi?id=187443

Summary Shrink various loading-related enums to shrink CachedResource

Simon Fraser (smfr)

Reported 2018-07-07 22:28:52 PDT

Shrink various loading-related enums to shrink CachedResource

Attachments
Patch (208.36 KB, patch) 2018-07-07 22:34 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.29 MB, application/zip) 2018-07-07 23:52 PDT, EWS Watchlist	no flags	Details
Patch (213.30 KB, patch) 2018-07-08 09:22 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (214.21 KB, patch) 2018-07-08 09:39 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (216.98 KB, patch) 2018-07-08 10:51 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.24 MB, application/zip) 2018-07-08 12:49 PDT, EWS Watchlist	no flags	Details
Patch (216.88 KB, patch) 2018-07-09 13:32 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-07-07 22:34:59 PDT

Created attachment 344538 [details] Patch

EWS Watchlist

Comment 2 2018-07-07 22:38:08 PDT

Attachment 344538 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 101 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-07-07 23:52:06 PDT

Comment on attachment 344538 [details] Patch Attachment 344538 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8471607 New failing tests: media/media-fullscreen-return-to-inline.html

EWS Watchlist

Comment 4 2018-07-07 23:52:08 PDT

Created attachment 344539 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 5 2018-07-08 09:22:38 PDT

Created attachment 344546 [details] Patch

EWS Watchlist

Comment 6 2018-07-08 09:25:08 PDT

Attachment 344546 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 104 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 7 2018-07-08 09:39:57 PDT

Created attachment 344547 [details] Patch

EWS Watchlist

Comment 8 2018-07-08 09:41:18 PDT

Attachment 344547 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 105 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 9 2018-07-08 10:51:30 PDT

Created attachment 344549 [details] Patch

EWS Watchlist

Comment 10 2018-07-08 10:52:54 PDT

Attachment 344549 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 11 2018-07-08 12:49:29 PDT

Comment on attachment 344549 [details] Patch Attachment 344549 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8475502 New failing tests: animations/needs-layout.html

EWS Watchlist

Comment 12 2018-07-08 12:49:31 PDT

Created attachment 344551 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Simon Fraser (smfr)

Comment 13 2018-07-09 13:32:20 PDT

Created attachment 344607 [details] Patch

EWS Watchlist

Comment 14 2018-07-09 13:34:20 PDT

Attachment 344607 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 15 2018-07-09 14:03:03 PDT

Comment on attachment 344607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344607&action=review > Source/WebCore/loader/FetchOptions.h:60 > + String integrity; Shouldn't we move this one up instead? I think we usually order from bigger to smaller types. > Source/WebCore/loader/FetchOptions.h:61 > std::optional<DocumentIdentifier> clientIdentifier; ditto.

WebKit Commit Bot

Comment 16 2018-07-09 16:54:26 PDT

Comment on attachment 344607 [details] Patch Clearing flags on attachment: 344607 Committed r233668: <https://trac.webkit.org/changeset/233668>

WebKit Commit Bot

Comment 17 2018-07-09 16:54:28 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2018-07-09 16:55:33 PDT

<rdar://problem/41997321>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Simon Fraser (smfr)

Reported

2018-07-07 22:28 PDT

Modified

2018-07-09 16:55 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks