Shrink various loading-related enums to shrink CachedResource
Created attachment 344538 [details] Patch
Attachment 344538 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 101 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 344538 [details] Patch Attachment 344538 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8471607 New failing tests: media/media-fullscreen-return-to-inline.html
Created attachment 344539 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 344546 [details] Patch
Attachment 344546 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 104 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 344547 [details] Patch
Attachment 344547 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 105 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 344549 [details] Patch
Attachment 344549 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 344549 [details] Patch Attachment 344549 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8475502 New failing tests: animations/needs-layout.html
Created attachment 344551 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 344607 [details] Patch
Attachment 344607 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:911: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 344607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344607&action=review > Source/WebCore/loader/FetchOptions.h:60 > + String integrity; Shouldn't we move this one up instead? I think we usually order from bigger to smaller types. > Source/WebCore/loader/FetchOptions.h:61 > std::optional<DocumentIdentifier> clientIdentifier; ditto.
Comment on attachment 344607 [details] Patch Clearing flags on attachment: 344607 Committed r233668: <https://trac.webkit.org/changeset/233668>
All reviewed patches have been landed. Closing bug.
<rdar://problem/41997321>