RESOLVED FIXED 187441
[JSC] Optimize layout of CodeBlock to reduce padding 
https://bugs.webkit.org/show_bug.cgi?id=187441
Summary [JSC] Optimize layout of CodeBlock to reduce padding
Yusuke Suzuki
Reported 2018-07-07 14:36:31 PDT
[JSC] Optimize layout of CodeBlock to reduce padding
Attachments
Patch (25.87 KB, patch)
2018-07-07 14:41 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (19.12 MB, application/zip)
2018-07-07 16:45 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-07 14:41:53 PDT
Created attachment 344529 [details] Patch
EWS Watchlist
Comment 2 2018-07-07 14:43:35 PDT
Attachment 344529 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:375: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 3 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2018-07-07 14:59:44 PDT
Comment on attachment 344529 [details] Patch r=me
EWS Watchlist
Comment 4 2018-07-07 16:45:12 PDT
Comment on attachment 344529 [details] Patch Attachment 344529 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8469324 New failing tests: animations/needs-layout.html
EWS Watchlist
Comment 5 2018-07-07 16:45:14 PDT
Created attachment 344532 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
WebKit Commit Bot
Comment 6 2018-07-08 10:59:32 PDT
Comment on attachment 344529 [details] Patch Clearing flags on attachment: 344529 Committed r233630: <https://trac.webkit.org/changeset/233630>
WebKit Commit Bot
Comment 7 2018-07-08 10:59:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-07-08 11:02:15 PDT
<rdar://problem/41950526>
Yusuke Suzuki
Comment 9 2018-07-08 21:37:30 PDT
Committed r233633: <https://trac.webkit.org/changeset/233633>
Note You need to log in before you can comment on or make changes to this bug.