<rdar://problem/39948240>
Created attachment 344493 [details] Patch
Comment on attachment 344493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344493&action=review Seems reasonable, though some bits could use an anttik once-over. > Source/WebCore/ChangeLog:3 > + Semantic colors don't update with accessibility Increase Contrast mode is enabled. s/with/when/?
Created attachment 344495 [details] Patch
Comment on attachment 344495 [details] Patch Rejecting attachment 344495 [details] from commit-queue. New failing tests: media/media-fullscreen-return-to-inline.html Full output: https://webkit-queues.webkit.org/results/8462792
Created attachment 344502 [details] Archive of layout-test-results from webkit-cq-02 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-sierra Platform: Mac OS X 10.12.6
The commit-queue encountered the following flaky tests while processing attachment 344495 [details]: media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 344495 [details] Patch Clearing flags on attachment: 344495 Committed r233612: <https://trac.webkit.org/changeset/233612>
All reviewed patches have been landed. Closing bug.
Comment on attachment 344495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344495&action=review > Source/WebCore/page/Page.cpp:536 > + if (StyleResolver* styleResolver = document->styleScope().resolverIfExists()) > + styleResolver->invalidateMatchedPropertiesCache(); > + document->scheduleForcedStyleRecalc(); > + document->styleScope().didChangeStyleSheetEnvironment(); Only the last one of these should really be needed (the rest are harmless though).
(In reply to Antti Koivisto from comment #9) > Comment on attachment 344495 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344495&action=review > > > Source/WebCore/page/Page.cpp:536 > > + if (StyleResolver* styleResolver = document->styleScope().resolverIfExists()) > > + styleResolver->invalidateMatchedPropertiesCache(); > > + document->scheduleForcedStyleRecalc(); > > + document->styleScope().didChangeStyleSheetEnvironment(); > > Only the last one of these should really be needed (the rest are harmless > though). They all seemed to be needed in my testing.
looks like after r233612 we are having one api test fail on all platforms. Link to output of test failure: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5489/steps/run-api-tests/logs/stdio excerpt: Test suite failed Failed TestWebKitAPI.WebKit.LinkColorWithSystemAppearance /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:56 Value of: linkColor Actual: "rgb(0, 0, 238)" Expected: "rgb(0, 105, 217)"
Re-opened since this is blocked by bug 187475
Created attachment 344625 [details] Patch
Created attachment 344626 [details] Patch
The commit-queue encountered the following flaky tests while processing attachment 344626 [details]: media/video-fullscreen-reload-crash.html bug 187489 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 344626 [details]: media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 344626 [details] Patch Clearing flags on attachment: 344626 Committed r233670: <https://trac.webkit.org/changeset/233670>
After r233670 we are having the same api test failure on all platforms. Link to output of test failure: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5539/steps/run-api-tests/logs/stdio excerpt: Test suite failed Failed TestWebKitAPI.WebKit.LinkColorWithSystemAppearance /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:56 Value of: linkColor Actual: "rgb(0, 105, 217)" Expected: "rgb(0, 104, 218)" It is good to note though that the actual and expected color is only off by one point this time.
(In reply to Truitt Savell from comment #19) > After r233670 we are having the same api test failure on all platforms. > > Link to output of test failure: > https://build.webkit.org/builders/ > Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5539/steps/run- > api-tests/logs/stdio > > excerpt: > Test suite failed > > Failed > > TestWebKitAPI.WebKit.LinkColorWithSystemAppearance > > > /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/ > WebKitCocoa/SystemColors.mm:56 > Value of: linkColor > Actual: "rgb(0, 105, 217)" > Expected: "rgb(0, 104, 218)" > > It is good to note though that the actual and expected color is only off by > one point this time. It seems this differs from macOS 10.14 and previous systems.
(In reply to Timothy Hatcher from comment #20) > (In reply to Truitt Savell from comment #19) > > After r233670 we are having the same api test failure on all platforms. > > > > Link to output of test failure: > > https://build.webkit.org/builders/ > > Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5539/steps/run- > > api-tests/logs/stdio > > > > excerpt: > > Test suite failed > > > > Failed > > > > TestWebKitAPI.WebKit.LinkColorWithSystemAppearance > > > > > > /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/ > > WebKitCocoa/SystemColors.mm:56 > > Value of: linkColor > > Actual: "rgb(0, 105, 217)" > > Expected: "rgb(0, 104, 218)" > > > > It is good to note though that the actual and expected color is only off by > > one point this time. > > It seems this differs from macOS 10.14 and previous systems. Are we tracking a fix for this somewhere?