Bug 187419 – [Curl] Remove unused AuthenticationManager static methods.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

These are not implemented and added accidentally.

[Basuke Suzuki]

Created attachment 344472 [details]
PATCH

I assume we can remove these static method declarations from Source/WebKit/Shared/Authentication/AuthenticationManager.h:

    static void receivedCredential(const WebCore::AuthenticationChallenge&, const WebCore::Credential&);
    static void receivedRequestToContinueWithoutCredential(const WebCore::AuthenticationChallenge&);
    static void receivedCancellation(const WebCore::AuthenticationChallenge&);
    static void receivedRequestToPerformDefaultHandling(const WebCore::AuthenticationChallenge&);
    static void receivedChallengeRejection(const WebCore::AuthenticationChallenge&);

[EWS Watchlist]

Comment on attachment 344472 [details]
PATCH

Attachment 344472 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8461431

New failing tests:
media/media-fullscreen-return-to-inline.html

[EWS Watchlist]

Created attachment 344488 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Fujii Hironori]

Curl port is the only port to implement the class methods.
You can remove the declarations.
https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h?rev=232613#L83

[Basuke Suzuki]

Created attachment 344599 [details]
PATCH

[Basuke Suzuki]

(In reply to Fujii Hironori from comment #4)
> Curl port is the only port to implement the class methods.
> You can remove the declarations.
> https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Shared/
> Authentication/AuthenticationManager.h?rev=232613#L83

Thanks for confirmation.

[Yusuke Suzuki]

Comment on attachment 344599 [details]
PATCH

r=me

[Basuke Suzuki]

Thanks, Yusuke.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 344599 [details]:

media/media-fullscreen-pause-inline.html bug 187387 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 344599 [details]:

media/media-fullscreen-return-to-inline.html bug 187387 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 344599 [details]
PATCH

Clearing flags on attachment: 344599

Committed r233654: <https://trac.webkit.org/changeset/233654>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41984802>