Bug 187418 - WebDriver: hang in Selenium test alerts_tests.py::testShouldHandleAlertOnPageBeforeUnload
Summary: WebDriver: hang in Selenium test alerts_tests.py::testShouldHandleAlertOnPage...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-06 15:26 PDT by BJ Burg
Modified: 2018-07-09 09:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2018-07-06 15:33 PDT, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-07-06 15:26:05 PDT
This test does not seem to be spec-conformant (beforeunload alerts should be dismissed automatically), but it shouldn't hang either.
Comment 1 BJ Burg 2018-07-06 15:26:29 PDT
<rdar://problem/41909520>
Comment 2 BJ Burg 2018-07-06 15:33:48 PDT
Created attachment 344467 [details]
Patch
Comment 3 WebKit Commit Bot 2018-07-06 16:11:09 PDT
Comment on attachment 344467 [details]
Patch

Clearing flags on attachment: 344467

Committed r233600: <https://trac.webkit.org/changeset/233600>
Comment 4 WebKit Commit Bot 2018-07-06 16:11:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 BJ Burg 2018-07-09 09:30:42 PDT
Committed r233641: <https://trac.webkit.org/changeset/233641>