Bug 187404 - Check that LayerTreeHost was created before use
Summary: Check that LayerTreeHost was created before use
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-06 13:01 PDT by Stephan Szabo
Modified: 2018-07-09 20:06 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2018-07-06 13:03 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-07-06 13:01:48 PDT 
Check that LayerTreeHost was created before use
Comment 1 Stephan Szabo 2018-07-06 13:03:39 PDT 
Created attachment 344443 [details]
Patch
Comment 2 Stephan Szabo 2018-07-06 13:05:21 PDT 
I'm not sure if this is the best way to handle this, but while working on web inspector for wincairo non-legacy, we hit crashes just after this point because LayerTreeHost::create returns nullptr if not USE(COORDINATED_GRAPHICS_THREADED) but this code acts as if it will always get one.
Comment 3 Fujii Hironori 2018-07-08 22:00:28 PDT 
I think Windows WK2 MiniBrowser should disable AC by using WKPreferencesSetAcceleratedDrawingEnabled until AC is supported.
Comment 4 Fujii Hironori 2018-07-08 22:12:10 PDT 
Ah. Your primary aim is the web inspector. IIRC, the web inspector is using AC to paint element highlights.
Comment 5 Fujii Hironori 2018-07-09 01:59:53 PDT 
Stephan, what will happen in AC mode pages after applying your change? All becomes blank pages instead of having crash?
Comment 6 WebKit Commit Bot 2018-07-09 11:21:08 PDT 
Comment on attachment 344443 [details]
Patch

Clearing flags on attachment: 344443

Committed r233647: <https://trac.webkit.org/changeset/233647>
Comment 7 WebKit Commit Bot 2018-07-09 11:21:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-09 11:27:22 PDT 
<rdar://problem/41981386>
Comment 9 Fujii Hironori 2018-07-09 20:06:25 PDT 
Bug 187503 – [Win][MiniBrowser] Disable accelerated compositing until it is supported