Bug 187396 - [iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle
Summary: [iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-06 11:06 PDT by Andy Estes
Modified: 2018-07-06 13:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2018-07-06 11:09 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (3.09 KB, patch)
2018-07-06 12:39 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-07-06 11:06:27 PDT 
[iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle
Comment 1 Andy Estes 2018-07-06 11:07:07 PDT 
rdar://problem/41786980
Comment 2 Andy Estes 2018-07-06 11:09:30 PDT 
Created attachment 344429 [details]
Patch
Comment 3 Andy Estes 2018-07-06 12:39:41 PDT 
Created attachment 344440 [details]
Patch
Comment 4 WebKit Commit Bot 2018-07-06 13:09:30 PDT 
The commit-queue encountered the following flaky tests while processing attachment 344440 [details]:

media/media-fullscreen-pause-inline.html bug 187406 (author: jeremyj-wk@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2018-07-06 13:09:41 PDT 
The commit-queue encountered the following flaky tests while processing attachment 344440 [details]:

media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2018-07-06 13:13:30 PDT 
Comment on attachment 344440 [details]
Patch

Clearing flags on attachment: 344440

Committed r233589: <https://trac.webkit.org/changeset/233589>
Comment 7 WebKit Commit Bot 2018-07-06 13:13:31 PDT 
All reviewed patches have been landed.  Closing bug.