Bug 187392 - WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler() should take in a CompletionHandler
Summary: WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler() should ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-06 09:34 PDT by Chris Dumez
Modified: 2018-07-06 12:35 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2018-07-06 09:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (13.01 MB, application/zip)
2018-07-06 10:48 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-06 09:34:23 PDT 
WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler() should take in a CompletionHandler instead of a Function.
Comment 1 Chris Dumez 2018-07-06 09:35:25 PDT 
Created attachment 344422 [details]
Patch
Comment 2 EWS Watchlist 2018-07-06 10:48:14 PDT 
Comment on attachment 344422 [details]
Patch

Attachment 344422 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8456880

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 3 EWS Watchlist 2018-07-06 10:48:25 PDT 
Created attachment 344428 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 WebKit Commit Bot 2018-07-06 12:33:12 PDT 
Comment on attachment 344422 [details]
Patch

Clearing flags on attachment: 344422

Committed r233587: <https://trac.webkit.org/changeset/233587>
Comment 5 WebKit Commit Bot 2018-07-06 12:33:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-06 12:35:10 PDT 
<rdar://problem/41903206>