...
Created attachment 344417 [details] WIP I started a patch but don't have time to finish it right now.
Created attachment 344435 [details] Patch
Comment on attachment 344435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344435&action=review > Tools/ChangeLog:14 > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=187384 > + > + And make it usable inside the sandbox even when > + perl is launched "tainted" (as the PERL5LIB won't > + work otherwise). > + > + Reviewed by NOBODY (OOPS!). This is messed up!
Created attachment 344451 [details] Patch =I should fix the webkit-patch script at some point :-)
Ha... bug title doesn't match in changelog...
Comment on attachment 344451 [details] Patch Rejecting attachment 344451 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 344451, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=344451&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=187384&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 344451 from bug 187384. Fetching: https://bugs.webkit.org/attachment.cgi?id=344451 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/flatpak/flatpakutils.py Hunk #1 FAILED at 654. 1 out of 1 hunk FAILED -- saving rejects to file Tools/flatpak/flatpakutils.py.rej patching file Tools/flatpak/org.webkit.WebKit.yaml Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/8467185
This needs some ChangeLog love :)
Comment on attachment 344451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344451&action=review > Tools/ChangeLog:3 > + [WPE][GTK] Install perl CGI inside the sandbox This should match the actual bug title
Created attachment 344577 [details] Patch for landing
Comment on attachment 344577 [details] Patch for landing Clearing flags on attachment: 344577 Committed r233639: <https://trac.webkit.org/changeset/233639>
All reviewed patches have been landed. Closing bug.
<rdar://problem/41970307>