Bug 187381 - [GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
Summary: [GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2018-07-06 01:57 PDT by Carlos Garcia Campos
Modified: 2018-07-09 01:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2018-07-06 01:58 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.29 MB, application/zip)
2018-07-06 03:03 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-07-06 01:57:32 PDT 
This is because the static variable for proxy settings was replaced by a NeverDestroyed, but the function is not returning a reference, but a copy. This is causing several unit tests to fail.
Comment 1 Carlos Garcia Campos 2018-07-06 01:58:31 PDT 
Created attachment 344409 [details]
Patch
Comment 2 EWS Watchlist 2018-07-06 03:03:35 PDT 
Comment on attachment 344409 [details]
Patch

Attachment 344409 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8454537

New failing tests:
media/media-fullscreen-return-to-inline.html
Comment 3 EWS Watchlist 2018-07-06 03:03:37 PDT 
Created attachment 344415 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Yusuke Suzuki 2018-07-06 03:11:33 PDT 
Comment on attachment 344409 [details]
Patch

r=me, nice!
Comment 5 Adrian Perez 2018-07-06 03:32:10 PDT 
Comment on attachment 344409 [details]
Patch

Wow, good catch \o/
Comment 6 WebKit Commit Bot 2018-07-06 03:38:53 PDT 
Comment on attachment 344409 [details]
Patch

Clearing flags on attachment: 344409

Committed r233575: <https://trac.webkit.org/changeset/233575>
Comment 7 WebKit Commit Bot 2018-07-06 03:38:55 PDT 
All reviewed patches have been landed.  Closing bug.