Bug 187368 - REGRESSION(r233539): Changes made for youtube crashes has caused 15 api failures (Requested by Truitt on #webkit).
Summary: REGRESSION(r233539): Changes made for youtube crashes has caused 15 api failu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 187316
  Show dependency treegraph
 
Reported: 2018-07-05 16:08 PDT by WebKit Commit Bot
Modified: 2018-07-05 16:25 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r233539 (12.91 KB, patch)
2018-07-05 16:08 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2018-07-05 16:08:47 PDT
https://trac.webkit.org/changeset/233539 broke the build:
Changes made for youtube crashes has caused 15 api failures (Requested by Truitt on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2018-07-05 16:08:57 PDT
Created attachment 344377 [details]
ROLLOUT of r233539

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ryosuke Niwa 2018-07-05 16:09:19 PDT
Comment on attachment 344377 [details]
ROLLOUT of r233539

I know how to fix this.
Comment 3 Ryosuke Niwa 2018-07-05 16:22:50 PDT
Comment on attachment 344377 [details]
ROLLOUT of r233539

Hm... there is one test still failing after fixing the timer.
Comment 4 WebKit Commit Bot 2018-07-05 16:24:59 PDT
Comment on attachment 344377 [details]
ROLLOUT of r233539

Clearing flags on attachment: 344377

Committed r233549: <https://trac.webkit.org/changeset/233549>
Comment 5 WebKit Commit Bot 2018-07-05 16:25:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-05 16:25:24 PDT
<rdar://problem/41869621>