RESOLVED FIXED 187365
[ews-build] EWS should run javascriptcore tests 
https://bugs.webkit.org/show_bug.cgi?id=187365
Summary [ews-build] EWS should run javascriptcore tests
Aakash Jain
Reported 2018-07-05 15:00:21 PDT
EWS should run JSC tests. This is part 2. Part 1 in https://bugs.webkit.org/show_bug.cgi?id=187201 added support for Building JSC.
Attachments
Proposed patch (4.51 KB, patch)
2018-07-05 15:05 PDT, Aakash Jain 		ddkilzer: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.91 MB, application/zip)
2018-07-05 17:14 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-07-05 15:05:56 PDT
Created attachment 344371 [details] Proposed patch
EWS Watchlist
Comment 2 2018-07-05 15:08:42 PDT
Attachment 344371 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:503: [TestRunJavaScriptCoreTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:503: [TestRunJavaScriptCoreTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:518: [TestRunJavaScriptCoreTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:518: [TestRunJavaScriptCoreTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 3 2018-07-05 16:04:16 PDT
Comment on attachment 344371 [details] Proposed patch r=me if you fix the style checker warnings.
EWS Watchlist
Comment 4 2018-07-05 17:14:30 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 5 2018-07-05 17:14:41 PDT
Created attachment 344384 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Aakash Jain
Comment 6 2018-07-06 12:24:23 PDT
style checker warnings are false positive.
Aakash Jain
Comment 7 2018-07-06 12:24:31 PDT
Sample run: http://ews-build.webkit-uat.org/#/builders/17/builds/13
Aakash Jain
Comment 8 2018-07-06 12:25:51 PDT
Committed r233586: <https://trac.webkit.org/changeset/233586>.
Radar WebKit Bug Importer
Comment 9 2018-07-06 12:27:11 PDT
<rdar://problem/41902879>
Note You need to log in before you can comment on or make changes to this bug.