Bug 187365 - [ews-build] EWS should run javascriptcore tests
Summary: [ews-build] EWS should run javascriptcore tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-05 15:00 PDT by Aakash Jain
Modified: 2018-07-06 12:27 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (4.51 KB, patch)
2018-07-05 15:05 PDT, Aakash Jain
ddkilzer: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.91 MB, application/zip)
2018-07-05 17:14 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-07-05 15:00:21 PDT
EWS should run JSC tests.

This is part 2. 
Part 1 in https://bugs.webkit.org/show_bug.cgi?id=187201 added support for Building JSC.
Comment 1 Aakash Jain 2018-07-05 15:05:56 PDT
Created attachment 344371 [details]
Proposed patch
Comment 2 EWS Watchlist 2018-07-05 15:08:42 PDT
Attachment 344371 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:503:  [TestRunJavaScriptCoreTests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:503:  [TestRunJavaScriptCoreTests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:518:  [TestRunJavaScriptCoreTests.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:518:  [TestRunJavaScriptCoreTests.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2018-07-05 16:04:16 PDT
Comment on attachment 344371 [details]
Proposed patch

r=me if you fix the style checker warnings.
Comment 4 EWS Watchlist 2018-07-05 17:14:30 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-07-05 17:14:41 PDT
Created attachment 344384 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Aakash Jain 2018-07-06 12:24:23 PDT
style checker warnings are false positive.
Comment 7 Aakash Jain 2018-07-06 12:24:31 PDT
Sample run: http://ews-build.webkit-uat.org/#/builders/17/builds/13
Comment 8 Aakash Jain 2018-07-06 12:25:51 PDT
Committed r233586: <https://trac.webkit.org/changeset/233586>.
Comment 9 Radar WebKit Bug Importer 2018-07-06 12:27:11 PDT
<rdar://problem/41902879>