iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover

[Olivia Barnett]

iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover

[Olivia Barnett]

Created attachment 344368 [details]
Patch

[Tim Horton]

Comment on attachment 344368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344368&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3686
> +    if (_assistedNodeInformation.elementType != InputType::Select) {

I don't think this is quite right, because pageup/pagedown and spacebar will still scroll.

Instead, I think you should bail at the top of the function similar to what we do in the isContentEditable case.

[Olivia Barnett]

Created attachment 344374 [details]
Patch

[Tim Horton]

Comment on attachment 344374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344374&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3645
> +    if (_assistedNodeInformation.elementType == InputType::Select)

We probably want to add other types to this list (are there other kinds of assisted nodes that use popovers?), but this is a good start.

[WebKit Commit Bot]

Comment on attachment 344374 [details]
Patch

Clearing flags on attachment: 344374

Committed r233553: <https://trac.webkit.org/changeset/233553>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41872234>