Bug 187357 – [ews-build] Add build step to UnApply patch

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

When a patch fails to build or fails layout-tests, EWS should unapply the patch and build/test again. We should add the build step to unapply the patch.

[Aakash Jain]

Created attachment 344360 [details]
Proposed patch

Tested in http://ews-build.webkit-uat.org/#/builders/9/builds/22

[EWS Watchlist]

Attachment 344360 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:72:  [UnApplyPatchIfRequired.__init__] Use of super on an old style class  [pylint/E1002] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 344360 [details]
Proposed patch

Attachment 344360 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8450316

New failing tests:
http/tests/security/local-video-source-from-remote.html

[EWS Watchlist]

Created attachment 344385 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Aakash Jain]

Committed r233708: <https://trac.webkit.org/changeset/233708>

[Radar WebKit Bug Importer]

<rdar://problem/42047134>

[Daniel Bates]

Comment on attachment 344360 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344360&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:73
> +        super(UnApplyPatchIfRequired, self).__init__(alwaysUseLatest=True, **kwargs)

From my understanding setting alwaysUseLatest to true both cleans the working directory and pulls down new source changes. This represents a behavior change from the current EWS. The current EWS actually unapplies the patch. It does this implicitly by cleaning the working directory. That is, it does not both clean the working directory and pull down new source changes.