Bug 187350 - REGRESSION: Web Inspector no longer pauses in internal injected scripts like WDFindNodes.js
Summary: REGRESSION: Web Inspector no longer pauses in internal injected scripts like ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-05 10:49 PDT by BJ Burg
Modified: 2022-03-01 02:29 PST (History)
12 users (show)

See Also:

Attachments
Patch (18.96 KB, patch)
2018-07-05 11:00 PDT, BJ Burg 		mattbaker: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-07-05 10:49:34 PDT 
This seems to be fallout from internal script black boxing.
Comment 1 BJ Burg 2018-07-05 10:49:56 PDT 
<rdar://problem/41728249>
Comment 2 BJ Burg 2018-07-05 11:00:05 PDT 
Created attachment 344343 [details]
Patch
Comment 3 Matt Baker 2018-07-09 09:54:57 PDT 
Comment on attachment 344343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344343&action=review

r=me

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:887
> +void InspectorDebuggerAgent::setPauseForInternalScripts(ErrorString &, bool shouldPause)

Style: pointer types and reference types should be written with no space between the type name and the * or & (https://webkit.org/code-style-guidelines/#pointers-cpp)

> Source/WebInspectorUI/UserInterface/Base/Setting.js:136
> +    pauseForInternalScripts: new WI.Setting("pause-for-internal-scripts", false),

Nice cleanup.
Comment 4 BJ Burg 2018-07-09 13:00:41 PDT 
Committed r233655: <https://trac.webkit.org/changeset/233655>