Bug 18735 – SQUIRRELFISH: closures are sometimes given an incorrect 'this' value when called

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Cameron Zwarich (cpst)]

Consider the following example:

---

var text = "PASS";

function a()
{
  var text = "FAIL";
  function b()
  {
    alert(this.text);
  }

  this.c = function()
  {
    b();
  }
  b();
}

(new a()).c();

---

This code should print PASS twice, but instead prints PASS once and then FAIL. This affects the JavaScriptCore test js1_5/Scope/scope-003.js.

[Cameron Zwarich (cpst)]

Created attachment 20812 [details]
Proposed patch

This patch fixes js1_5/Scope/scope-003.js, and it also fixes ecma/String/15.5.4.6-2.js.

[Cameron Zwarich (cpst)]

Created attachment 20813 [details]
Revised proposed patch

The ecma/String/15.5.4.6-2.js fix doesn't seem legitimate, so I modified the ChangeLog to reflect this.

[Cameron Zwarich (cpst)]

(In reply to comment #2)
> Created an attachment (id=20813) [edit]
> Revised proposed patch

SunSpider shows no change for this patch.

[Geoffrey Garen]

Comment on attachment 20813 [details]
Revised proposed patch

r=me

[Geoffrey Garen]

Committed revision 32536.

[Cameron Zwarich (cpst)]

Upon further review, this patch really did legitimately fix that test case after all.